Proposal to adopt event based pruner to tektoncd org #1208
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
|
|
||
| 1. The pruner must operate efficiently and scale well in large Tekton clusters. | ||
|
|
||
| 2. Resource cleanup must only occur after a PipelineRun or TaskRun is fully completed (either succeeded or failed). |
There was a problem hiding this comment.
This makes sense, however for users of results and chains this may not be enough.
We would need the ability to preserve resources until specific annotations are added to them, to ensure they are not removed before they have been processed by other downstream clients.
There was a problem hiding this comment.
@afrittoli chains and results are setting finalizers on objects for this reason (to be sure it doesn't get deleted before they can do something about it)
There was a problem hiding this comment.
Thank @anithapriyanatarajan for this very interesting proposal.
If I understood correctly, this would be a new project in the tektoncd org.
There some additional questions that the TEP should address, in particular who will maintain the project, see the link for more details.
The @tektoncd/governing-board needs to vote on this, however @tektoncd/results-maintainers and @tektoncd/operator-maintainers may want to review as well.
@afrittoli @vdemeester - Thankyou. Captured the required details in the Issue#1209. Please verify and suggest if anything further needs to be added. |
This PR includes the TEP to adopt Event-based-Pruner to the tektoncd org.
The Event-based-Pruner proposes an event triggered mechanism to cleanup completed PipelineRuns and TaskRuns as and when the Runs are completed based on pruner configurations defined in a configMap.