ci: fail on issues found in static-checks #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflow to fail when static-check issues are detected and adds a conditional execution for the release process.
- Removed the argument "--issues-exit-code=0" from the Go linter step, ensuring that the CI now fails on static-check issues.
- Added an ID for the semantic release step and introduced a conditional for running GoReleaser based on the outcome of semantic release.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/reusable-go-ci.yaml | Updated lint command arguments to fail on detected issues by removing '--issues-exit-code=0'. |
| .github/workflows/release.yaml | Added semantic_release step identifier and a conditional for running GoReleaser based on release outcome. |
Comments suppressed due to low confidence (1)
.github/workflows/release.yaml:58
- Ensure that the 'semantic_release' output always returns the string 'true' when a new release is published, so that the conditional execution for GoReleaser behaves as expected.
if: steps.semantic_release.outputs.new_release_published == 'true'
|
|
Coverage for common Download the latest HTML coverage report for common here. |
|
|
Coverage for common-server Download the latest HTML coverage report for common-server here. |
|
|
Coverage for secret-manager Download the latest HTML coverage report for secret-manager here. |
|
|
Coverage for approval Download the latest HTML coverage report for approval here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.