Skip to content

fix: Update handling of large array sizes #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

mattwittwer
Copy link
Contributor

@mattwittwer mattwittwer commented Apr 28, 2025

What does the PR do?

This PR adds an additional parameter to customize the maximum size allocatable by incoming requests. This can be useful in limiting very large input arrays

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Start with the new check added here. Then review the additional input added to main to set this value.

Test plan:

New tests added for json and raw binary inputs

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@mattwittwer mattwittwer self-assigned this Apr 28, 2025
@mattwittwer mattwittwer changed the title draft: Shape array vulnerability draft: Update handling of large array sizes May 1, 2025
@yinggeh
Copy link
Contributor

yinggeh commented May 6, 2025

Test case?

@statiraju statiraju requested a review from rmccorm4 May 7, 2025 18:26
@mattwittwer mattwittwer added the bug Something isn't working label May 12, 2025
@mattwittwer mattwittwer requested a review from tanmayv25 May 22, 2025 17:07
@mattwittwer mattwittwer changed the title draft: Update handling of large array sizes fix: Update handling of large array sizes May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants