Suggest Edits should strip CDATA

[subtleGradient]

Summary

Suggest Edits prompt uses XML. Some AI models insert CDATA notation. Zed sees the CDATA stuff as content. It shouldn't

When the AI suggests:

<new_text><![CDATA[THE NEW TEXT]]></new_text>

Zed tries to inject: <![CDATA[THE NEW TEXT]]>

It should inject: THE NEW TEXT instead

Zed Version and System Specs

Zed: v0.172.10 (Zed)
OS: macOS 15.1.0
Memory: 96 GiB
Architecture: aarch64

[subtleGradient]

i dunno rust (yet)
but ai suggested this: https://gist.github.com/subtleGradient/d01aca56a6662f70731ae61ebc672e64

[probably-neb]

Hmm, what models are generating CDATA for you?
The solution here may be just telling the AI not to use CDATA, but it would be useful to know which models are generating CDATA for you so we can figure out whether it's a model specific issue or if it's general enough and common enough that we should be checking for and handling it on every AI request

[stippi]

Actually, the LLM using this tag might be a good thing. Right now, the suggested edits better not contain </old_text>, </new_text> or any of the XML tags used for the tool invocation.

[stippi]

[probably-neb]

Interesting, but orthogonal point @stippi. Feel free to open a new issue for that if you'd like.

@subtleGradient Any chance you can provide more information about what models are providing CDATA re my earlier comment?

[subtleGradient]

IIRC is was one of the Gemini ones.
But I was also transforming some xml or html or something that would necessitate CDATA for proper formatting

I haven't seen it happen recently. But I also haven't been working on anything that would require CDATA so 🤷‍♂️

[SomeoneToIgnore]

I haven't seen it happen recently.

Closing as not happening then until more reports.