Fix diff indicators not restored when reopening remote project #31384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxbrunsfeld
previously requested changes
May 26, 2025
There was a problem hiding this comment.
Thanks for the investigation and fix @feeiyu. Nice work. Would you be open to adding a test to cover this fix, and prevent regressions? I think it's important for this fix, to help to make sure it's possible to refactor this without breaking it.
I think the best place for the test would be in remote_editing_tests.rs, similar to an existing test, test_remote_git_diffs.
|
Thank you for the review! I'll try to add test cases for these changes. |
cole-miller
force-pushed
the
fix_diff_indicator
branch
from
a4523bf to
b3833e2
Compare
cole-miller
force-pushed
the
fix_diff_indicator
branch
from
b3833e2 to
3e62e5f
Compare
cole-miller
requested review from
cole-miller
and removed request for
maxbrunsfeld
cole-miller
dismissed
maxbrunsfeld’s stale review
The requested test has been added and I've checked that it fails when the original patch is reverted, so I think this is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30917
Release Notes: