client: Fix an issue where non-IP proxy URLs didn’t resolve correctly #32664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
/cherry-pick v0.191.x |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…#32664) If the proxy URL is in the form of `example.com` instead of a raw IP address, and `example.com` isn't a well-known domain, then the default URL resolution can fail. The test setup: A Linux machine runs a CoreDNS server with a custom entry: `10.254.7.38 example.com`. On a Windows machine, if the proxy URL is set to `example.com`, the resolved address does **not** end up being `10.254.7.38`. Using `hickory_resolver` for more advanced DNS resolution fixes this issue. Release Notes: - Fixed proxy URL resolution when using custom DNS entries.
|
/cherry-pick v0.190.x |
|
Cherry-pick failed with |
JunkuiZhang
added a commit
that referenced
this pull request
Jun 13, 2025
… (cherry-pick #32664) (#32679) Cherry-picked client: Fix an issue where non-IP proxy URLs didn’t resolve correctly (#32664) If the proxy URL is in the form of `example.com` instead of a raw IP address, and `example.com` isn't a well-known domain, then the default URL resolution can fail. The test setup: A Linux machine runs a CoreDNS server with a custom entry: `10.254.7.38 example.com`. On a Windows machine, if the proxy URL is set to `example.com`, the resolved address does **not** end up being `10.254.7.38`. Using `hickory_resolver` for more advanced DNS resolution fixes this issue. Release Notes: - Fixed proxy URL resolution when using custom DNS entries. Co-authored-by: 张小白 <364772080@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the proxy URL is in the form of
example.cominstead of a raw IP address, andexample.comisn't a well-known domain, then the default URL resolution can fail.The test setup:
A Linux machine runs a CoreDNS server with a custom entry:
10.254.7.38 example.com. On a Windows machine, if the proxy URL is set toexample.com, the resolved address does not end up being10.254.7.38.Using
hickory_resolverfor more advanced DNS resolution fixes this issue.Release Notes: