Skip to content

Bail and signal error when the cwd of a resolved task doesn't exist #32777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Bail and signal error when the cwd of a resolved task doesn't exist #32777

merged 1 commit into from
Jun 16, 2025

Conversation

cole-miller
Copy link
Contributor

Closes #32688

Release Notes:

  • Fixed tasks (including build tasks for debug configurations) silently using / as a working directory when the specified cwd didn't exist.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 16, 2025
@cole-miller cole-miller self-assigned this Jun 16, 2025
@cole-miller cole-miller merged commit 22a2ff4 into main Jun 16, 2025
23 checks passed
@cole-miller cole-miller deleted the cwd-dne branch June 16, 2025 20:59
@SomeoneToIgnore
Copy link
Contributor

This fully breaks task running for remote projects, as the existence check seem to be run on a client.
If I run the real ssh connection, not the localhost one, I now get

image

instead of

expected

previously.

@cole-miller cole-miller mentioned this pull request Jun 17, 2025
Merged
cole-miller added a commit that referenced this pull request Jun 17, 2025
@cole-miller
Revert "Bail and signal error when the cwd of a resolved task doesn't…
6c7bcfe 
… exist" (#32866)

Reverts #32777
JosephTLyons pushed a commit that referenced this pull request Jun 17, 2025
@cole-miller @JosephTLyons
Bail and signal error when the cwd of a resolved task doesn't exist (#…
3f28664 
…32777)

Closes #32688

Release Notes:

- Fixed tasks (including build tasks for debug configurations) silently
using `/` as a working directory when the specified `cwd` didn't exist.
JosephTLyons pushed a commit that referenced this pull request Jun 17, 2025
@cole-miller @JosephTLyons
Revert "Bail and signal error when the cwd of a resolved task doesn't…
ec49967 
… exist" (#32866)

Reverts #32777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cole-miller cole-miller

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debugger: build.cwd silently changes the directory to / if target dir doesn't exist
2 participants
@cole-miller @SomeoneToIgnore