assistant_tools: Enable diff-fenced edit parser for all Gemini models #32812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
SomeoneToIgnore
added
the
ai
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw recently we added diff-fenced edit parser which improves the overall edit performance of gemini models in this PR: #32737. The idea is to enable it to all the models which has gemini as their id as this will help copilot and openrouter provider as they seem to aggregate all these models under one umbrella. I thought about adding a new method in LanguageModel as vendor_name() which returns the underlying actual model provider name but felt like a too early abstraction for a method to be used at one place.
cc @osyvokon
Release Notes: