Show inline previews for LSP document colors #32816
Merged
+1,796
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
imumesh18
reviewed
Jun 16, 2025
|
Hey, what do you think about using black or white as foreground color when the background option is enabled. example: |
|
I think of skipping this entirely, as for this we have to chunk the text differently, based on these LSP data mixins — that is quite a task on its own. |
# Conflicts: # crates/project/src/lsp_store.rs
SomeoneToIgnore
force-pushed
the
kb/document-colors
branch
from
4afb399 to
e0ebb1d
Compare
|
Do we support |
|
This is an initial version with RGBA support only for now, as the only thing that protocol defines. |
|
I added an discussion about |
|
Can't wait for this to land. Thank you for implementing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colors.mov
Closes #4678
Also adds the code to support
textDocument/colorPresentationcounterpart that serves as a resolve mechanism for the document colors.The resolve itself is not run though, and the editor does not accommodate color presentations in the editor yet — until a well described use case is provided.
Use
lsp_document_colorseditor settings to alter the presentation and turn the feature off.Release Notes: