extensions: Yet another PR for debugger touchups #32822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll now clean up DAP locators for unloaded extensions and load schemas proper
cla-bot
bot
added
the
cla-signed
osiewicz
force-pushed
the
dap-extensions-v1000000
branch
from
4b9d707 to
a2784e7
Compare
JosephTLyons
pushed a commit
that referenced
this pull request
Jun 17, 2025
We'll now clean up DAP locators for unloaded extensions and load schemas proper I can now load a custom Ruby extensions with all bells and whistles and use it as my debugger. Release Notes: - N/A
osiewicz
pushed a commit
that referenced
this pull request
Jun 19, 2025
Closes #33039 This PR fixes a bug which causes the newest versions of the Biome and Tombi extensions to not work with older Zed versions. The bug occurs because in #32822, the type of the debug adapter and debug locators was changed from a Vec to a BTreeMap. However, these fields were already introduced much earlier in Zed, which now causes the de-serialization of the `extension.toml` to fail for older Zed versions. Any extension compiled with the newest extension CLI bumped in zed-industries/extensions#2866 will not work with older Zed versions prior to v0.191. By adding this change and bumping the extension CLI again, this could be prevented. On de-serialization, we would just fallback to either a Vec for versions prior to v0.190 or a BTreeMap after. Feel free to let me know what you think here. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll now clean up DAP locators for unloaded extensions and load schemas proper
I can now load a custom Ruby extensions with all bells and whistles and use it as my debugger.
Release Notes: