Skip to content

Redact command environment variables from log output #32985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Redact command environment variables from log output #32985

wants to merge 1 commit into from
+45 −2

Conversation

notpeter
Copy link
Member

Before/After (linebreaks added for readability)

# before
INFO  [project::context_server_store::extension]
loaded command for context server mcp-server-github:
Command { 
  command: "/Users/peter/Library/Application Support/Zed/extensions/work/mcp-server-github/github-mcp-server-v0.5.0/github-mcp-server", 
  args: ["stdio"], 
  env: [("GITHUB_PERSONAL_ACCESS_TOKEN", "gho_WOOOOOOOOOOOOOOO")] 
}

#after
INFO  [project::context_server_store::extension]
loaded command for context server mcp-server-github:
Command {
  command: "/Users/peter/Library/Application Support/Zed/extensions/work/mcp-server-github/github-mcp-server-v0.5.0/github-mcp-server",
  args: ["stdio"],
  env: [("GITHUB_PERSONAL_ACCESS_TOKEN", "[REDACTED]")]
}

Release Notes:

  • Redact sensitive environment variables from MCP logs

@notpeter notpeter self-assigned this Jun 18, 2025
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 18, 2025
versecafe
versecafe reviewed Jun 18, 2025
View reviewed changes
crates/util/src/redact.rs
@@ -0,0 +1,8 @@
/// Whether a given environment variable name should have its value redacted
pub fn should_redact(env_var_name: &str) -> bool {
const REDACTED_SUFFIXES: &[&str] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also allow additional configs from zed settings or an env var for mcps with a sensitive value that doesn't contain one of these suffixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@versecafe versecafe versecafe left review comments

Assignees

@notpeter notpeter

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notpeter @versecafe