gpui: Add tab focus support #33008
Open
gpui: Add tab focus support #33008
+388
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
omg! Thank you! |
|
Apply this in GPUI Component, now focus management is very easy. Screen.Recording.2025-06-19.at.16.53.41.mov |
|
This is fantastic! 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
With a
tab_indexandtab_stopoption toFocusHandleto us can switch focus byTab,Shift-Tab.The
tab_indexis from WinUI and HTML tabindex, only thetab_stopis enabled that can be added into thetab_handleslist.window.focus_next()andwindow.focus_previous()method to switch focus.tab_indextoInteractiveElement.Screen.Recording.2025-06-19.at.18.48.02.mov