Replies: 2 comments 3 replies
-
About your first point — when you suggest dropping the bipolar-mask property, could you clarify how you plan to handle bipolar mode instead? Since zephyr,differential typically refers to input configuration rather than voltage encoding, do you see them as related, or would you propose a separate way to handle bipolar settings? |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi everyone. Writing some code to read a PT100 thermocouple via an AD7124 ADC, I was digging in the driver code and made some discoveries:
The
zephyr,differential
property on channels is ignored. Bipolarity can be set using thebipolar-mask
property on the device nodezephyr/drivers/adc/adc_ad7124.c
Line 418 in 74056a7
The
bipolar-mask
property could be dropped in favor of the channel configuration be me more compliant to the ADC apiSince AD7124 has two programmable excitation current sources, we could add two properties to set the current sources values (can be different) and enable the ADC_CONFIGURABLE_EXCITATION_CURRENT_SOURCE_PIN config
AD7124 provides two GPIO output pins, it could be useful to have a GPIO driver.
If it sounds reasonable, i could take in charge.
Beta Was this translation helpful? Give feedback.
All reactions