drivers: counter: migrate AGT counter to use FSP function #87881

New issue

Jump to bottom

Merged

kartben merged 6 commits into zephyrproject-rtos:main from renesas:renesas_ra_agt_counter_improvement

May 27, 2025

Collaborator

thenguyenyf commented Mar 31, 2025

Migrate the AGT counter implementation to use FSP r_agt APIs
Add support for AGT 32bit
Add ztests/samples support for Renesas RA boards

github-actions bot commented Mar 31, 2025 •

edited

Loading

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

github-actions bot added manifest manifest-hal_renesas DNM (manifest) labels

thenguyenyf force-pushed the renesas_ra_agt_counter_improvement branch from b4be15e to d8d59cc Compare

March 31, 2025 07:15

thenguyenyf marked this pull request as ready for review

March 31, 2025 07:31

github-actions bot added area: Counter area: Samples platform: Renesas RA labels

github-actions bot requested review from duynguyenxa, kartben, KhiemNguyenT, nashif, soburi and thaoluonguw

March 31, 2025 07:32

github-actions bot assigned nordic-krch

thenguyenyf force-pushed the renesas_ra_agt_counter_improvement branch 2 times, most recently from 756a8ad to a8dd5ee Compare

April 1, 2025 02:49

Collaborator Author

thenguyenyf commented Apr 1, 2025

Last push just to rebase and solve conflict

thenguyenyf force-pushed the renesas_ra_agt_counter_improvement branch from a8dd5ee to 5d21d8b Compare

April 1, 2025 06:05

thenguyenyf force-pushed the renesas_ra_agt_counter_improvement branch from 5d21d8b to 6e0f79c Compare

April 16, 2025 03:19

github-actions bot requested a review from nordic-krch

April 16, 2025 03:20

github-actions bot removed the DNM (manifest) label

Collaborator Author

thenguyenyf commented Apr 16, 2025

Hello @duynguyenxa , @thaoluonguw , @nordic-krch . Could you please take a look?

thenguyenyf force-pushed the renesas_ra_agt_counter_improvement branch from 6e0f79c to 3a515b0 Compare

May 14, 2025 01:41

github-actions bot removed manifest manifest-hal_renesas labels

thenguyenyf added this to the v4.2.0 milestone

duynguyenxa reviewed

View reviewed changes

drivers/counter/counter_renesas_ra_agt.c Outdated

-              		return -ENOTSUP;
+              	err = R_AGT_Start(&data->agt_ctrl);
+              	if (err != FSP_SUCCESS) {
+              		LOG_ERR("counter start failed");

Member

duynguyenxa May 14, 2025

@thenguyenyf , small nit, use upper for first letter

Collaborator Author

thenguyenyf May 16, 2025

I fixed it

drivers/counter/counter_renesas_ra_agt.c Outdated

+              	int ret = 0;
+              	if (cfg->ticks > config->info.max_top_value) {
+              		LOG_ERR("top value exceed maximum value");

Member

duynguyenxa May 14, 2025

diito

Collaborator Author

thenguyenyf May 16, 2025

I fixed it

drivers/counter/counter_renesas_ra_agt.c Outdated

-              		return -EBUSY;
+              	ret = renesas_ra_agt_period_set(dev, cfg->ticks);
+              	if (ret != 0) {
+              		LOG_ERR("counter period set failed");

Member

duynguyenxa May 14, 2025

ditto

Collaborator Author

thenguyenyf May 16, 2025

I fixed it

drivers/counter/counter_renesas_ra_agt.c Outdated

+              	if (reset) {
+              		err = R_AGT_Reset(&data->agt_ctrl);
+              		if (err != FSP_SUCCESS) {
+              			LOG_ERR("counter reset failed");

Member

duynguyenxa May 14, 2025

ditto

drivers/counter/counter_renesas_ra_agt.c Outdated

+              	int ret = 0;
+              	if (counter_renesas_ra_agt_get_top_value(dev) < guard) {
+              		LOG_ERR("invalid guard rate");

Member

duynguyenxa May 14, 2025

ditto

drivers/counter/counter_renesas_ra_agt.c Outdated

-              		/* No divider can be used when count source is AGT_CLOCK_AGT_UNDERFLOW */
+              	err = R_AGT_InfoGet(&data->agt_ctrl, &info);
+              	if (err != FSP_SUCCESS) {
+              		LOG_ERR("counter get freq failed");

Member

duynguyenxa May 14, 2025

ditto

drivers/counter/counter_renesas_ra_agt.c Outdated

-              	return FSP_SUCCESS;
-              }
+              		if (counter_renesas_ra_agt_get_value(dev, &now) != 0) {
+              			LOG_WRN("error in counter alarm");

Member

duynguyenxa May 14, 2025

ditto

Member

duynguyenxa commented May 14, 2025

hi @thenguyenyf , the renesas,resolution field is to differentiate between the agt (16-bit) and agtw (32-bit), so I think it's better be enum value in dt binding, could you also make the change for that.

thenguyenyf force-pushed the renesas_ra_agt_counter_improvement branch 2 times, most recently from 8cd48ec to 317daa7 Compare

May 21, 2025 01:53

thenguyenyf requested a review from duynguyenxa

May 21, 2025 01:54

thenguyenyf added 6 commits

May 22, 2025 10:57


          tests: counter: correct checkpoint for downward counter

f39b068

Modify the expected ticks check to adapt with a downward counter
instance

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>


          drivers: counter: migrate counter AGT to using HAL support

423f0a8

Migrate renesas,ra-agt-counter implementation to use hal_renesas.
Add additional AGT_CLOCK_SUBCLOCK count source.
Add constraint for counter resolution to 32 or 16 bit variant.

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>


          dts: arm: renesas: enable support AGT on Renesas RA device

6bb9b03

Add device node for AGT counter support on Renesas RA family

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>


          tests: counter: add support for renesas,ra-agt-counter

b9bd200

Enable test support for renesas,ra-agt-counter

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>


          samples: counter: alarm: add support for Renesas RA devices

7864aa8

Add overlay to enable counter node for Renesas RA devices

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>


          samples: counter: alarm: remove platform_allow filterring

230860d

Because this is a common testing scenario, almost any counter instance
should be able to run. Some counter instances cannot run this sample
should be filtered by platform_exclude or filter keywords.

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

thenguyenyf force-pushed the renesas_ra_agt_counter_improvement branch from 317daa7 to 230860d Compare

May 22, 2025 03:58

Collaborator Author

thenguyenyf commented May 22, 2025

Hello @thaoluonguw , @duynguyenxa , @nordic-krch . Could you please take a look?

sonarqubecloud bot commented May 22, 2025

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

thaoluonguw approved these changes

View reviewed changes

duynguyenxa approved these changes

View reviewed changes

nordic-krch approved these changes

View reviewed changes

kartben merged commit 022962c into zephyrproject-rtos:main

41 checks passed

thenguyenyf deleted the renesas_ra_agt_counter_improvement branch

May 27, 2025 09:51

butok reviewed

View reviewed changes

samples/drivers/counter/alarm/sample.yaml

-                    - s32z2xxdc2/s32z270/rtu1
-                    - s32z2xxdc2@D/s32z270/rtu0
-                    - s32z2xxdc2@D/s32z270/rtu1
-                    - lp_em_cc2340r5

Collaborator

butok May 27, 2025

Hi @thenguyenyf
This PR is causing CI errors: https://github.com/zephyrproject-rtos/zephyr/actions/runs/15273910745/job/42955888437?pr=90662
Please provide a fix or return platform_allow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Counter area: Samples platform: Renesas RA