Skip to content

Initial Support for ElemRV-N #89441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 14, 2025
Merged

Initial Support for ElemRV-N #89441

merged 7 commits into from
May 14, 2025

Conversation

dnltz
Copy link
Collaborator

@dnltz dnltz commented May 4, 2025

This pull-request adds initial support for ElemRV-N [0], an end-to-end open-source RISC-V microcontroller designed using SpinalHDL successfully tapped-out with IHP's Open PDK [1].

Support for interfaces already exists on my fork and will be added after this PR got merged.

0: https://github.com/aesc-silicon/elemrv
1: https://github.com/IHP-GmbH/IHP-Open-PDK

@dnltz dnltz requested a review from henrikbrixandersen May 4, 2025 08:39
@github-actions github-actions bot added area: Devicetree area: Process area: RISCV RISCV Architecture (32-bit & 64-bit) labels May 4, 2025
@dnltz dnltz force-pushed the WIP/dnltz/elemrv-n-board branch 7 times, most recently from 172fb17 to 999e99d Compare May 4, 2025 14:18
ycsin
ycsin reviewed May 4, 2025
View reviewed changes
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last commit should probably update doc/releases/release-notes-4.2.rst as well

henrikbrixandersen
henrikbrixandersen reviewed May 4, 2025
View reviewed changes
nashif
nashif reviewed May 8, 2025
View reviewed changes
@dnltz
Copy link
Collaborator Author

dnltz commented May 8, 2025

@nordicjm @ycsin @kartben sorry for staling your reviews. I added an uart driver to this pull-request to build and run the hello_world sample.

@dnltz dnltz requested review from nordicjm, ycsin and kartben May 8, 2025 15:47
@dnltz dnltz force-pushed the WIP/dnltz/elemrv-n-board branch 2 times, most recently from e553306 to a62e2ac Compare May 9, 2025 04:16
@dnltz dnltz requested a review from nashif May 9, 2025 04:36
henrikbrixandersen
henrikbrixandersen requested changes May 9, 2025
View reviewed changes
dts/bindings/vendor-prefixes.txt Outdated
@@ -33,6 +33,7 @@ adh AD Holdings Plc.
adi Analog Devices, Inc.
advantech Advantech Corporation
aeroflexgaisler Aeroflex Gaisler AB
aesc aesc silicon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lower-case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the name everywhere and capitalized it.

dts/riscv/aesc/nitrogen.dtsi Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it's called nitrogen elsewhere it's simply n? Can we use nitrogen all-over?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to stick to ElemRV-N at board level since that's the actual chip name. I'm fine with renaming the device-tree to elemrn-nitrogen.dtsi if that makes it better.

soc/aesc/vexriscv/Kconfig.soc Outdated
# Copyright (c) 2025 aesc silicon
# SPDX-License-Identifier: Apache-2.0

config SOC_FAMILY_AESC_VEXRISCV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the whole aesc, vexrisc, nitrogen, elemrv, n naming here. Is the family really vexriscv?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually after checking this comment I figured out that SOC_FAMILY_AESC_VEXRISCV is wrong and not required at all. I removed all these configs here.

dnltz added 2 commits May 9, 2025 19:01
@dnltz
dts: bindings: Add aesc
ec2d63a 
aesc silicon is a startup focused on developing open-source
silicon solutions.

Link: https://github.com/aesc-silicon/ElemRV

Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
@dnltz
MAINTAINERS: Add Aesc Platform
1ff6e93 
aesc silicon is a startup focused on developing open-source
silicon solutions.

Add a new platform to the MAINTAINERS file to ensure changes
get reviewed.

Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
@dnltz dnltz force-pushed the WIP/dnltz/elemrv-n-board branch from a62e2ac to e34bf89 Compare May 9, 2025 17:13
@dnltz dnltz requested a review from henrikbrixandersen May 10, 2025 10:58
ycsin
ycsin reviewed May 11, 2025
View reviewed changes
include/zephyr/drivers/aesc/ip_identification.h Outdated
@@ -0,0 +1,100 @@
/** @file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems too vendor-specific to be placed here, should this be in soc/aesc/... and exposed via zephyr_include_directories(.) instead?

Copy link
Collaborator Author

@dnltz dnltz May 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea! I was not very happy about the location too.

@dnltz dnltz force-pushed the WIP/dnltz/elemrv-n-board branch from e34bf89 to 02b631a Compare May 12, 2025 09:24
@dnltz dnltz requested a review from ycsin May 12, 2025 09:29
fkokosinski
fkokosinski requested changes May 12, 2025
View reviewed changes
dnltz added 5 commits May 12, 2025 17:08
@dnltz
soc: Add aesc
224f71b 
Currently, the only available platform is Nitrogen, featuring a
VexRiscv CPU that boots from external SPI flash and runs code from
external HyperRAM.

Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
@dnltz
drivers: serial: Add aesc UART driver
1080530 
Add minimal support for the aesc silicon UART IP core.

This core includes an internal clock divider and supports flexible
frame configurations, allowing for variable data length, parity, and
stop bit settings.

The current driver version does not support interrupts.

Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
@dnltz
dts: riscv: Add aesc
50b56dc 
ElemRV-N is based on the nitrogen SoC platform. Add the
base nitrogen device-tree and one for elemrv-n. The elemrv-n
device-tree will contain all IP cores later.

Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
@dnltz
boards: aesc: Add ElemRV-N
40ea935 
ElemRV-N is an end-to-end open-source microcontroller. This patch
adds basic support for the platform with any interfaces. They will
be added later since drivers are missing completly.

Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
@dnltz
doc: releases: Add ElemRV to Release Notes
f780572 
Add a note about initial support for ElemRV-N.

Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
@dnltz dnltz force-pushed the WIP/dnltz/elemrv-n-board branch from 02b631a to f780572 Compare May 12, 2025 15:09
@dnltz dnltz requested a review from fkokosinski May 12, 2025 15:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kartben kartben merged commit 55e8966 into zephyrproject-rtos:main May 14, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben

@henrikbrixandersen henrikbrixandersen

@fkokosinski fkokosinski

@nordicjm nordicjm

@carlocaione carlocaione

@decsny decsny

@edersondisouza edersondisouza

@katsuster katsuster

@kgugala kgugala

@MaureenHelm MaureenHelm

@mgielda mgielda

@npitre npitre

@stephanosio stephanosio

@tgorochowik tgorochowik

@VynDragon VynDragon

@nashif nashif

@ycsin ycsin

Assignees

@kgugala kgugala

@tgorochowik tgorochowik

@fkokosinski fkokosinski

Labels
area: Devicetree area: Process area: RISCV RISCV Architecture (32-bit & 64-bit) area: UART Universal Asynchronous Receiver-Transmitter Release Notes To be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dnltz @kartben @nashif @henrikbrixandersen @ycsin @fkokosinski @nordicjm @kgugala @tgorochowik