linker generator: Handle .last_section #89739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
reviewed
May 9, 2025
cmake/linker_script/arm/linker.cmake
Outdated
| # rom region data usage match when CONFIG_LINKER_LAST_SECTION_ID=y. | ||
| zephyr_linker_section(NAME .last_section VMA FLASH LMA FLASH NOINPUT) | ||
| # KEEP can not be passed to zephyr_linker_section, so: | ||
| zephyr_linker_section_configure(SECTION .last_section INPUT ".last_section" KEEP) |
There was a problem hiding this comment.
Missing newline at the end of the file :) you probably need to config your editor.
There was a problem hiding this comment.
Should be fixed now.
bjorniuppsala
force-pushed
the
last_section_for_cmake_linker_gen
branch
from
b2fbffb to
13e4ae6
Compare
|
Hmm. On closer inspection this didnt solve the problem. I'll be back |
bjorniuppsala
force-pushed
the
last_section_for_cmake_linker_gen
branch
4 times, most recently
from
fb61ec6 to
8ae871a
Compare
Add cmake linker generator things for .last_section. Follow up to zephyrproject-rtos#88970. Fixes bug zephyrproject-rtos#89719, for gcc/ld & iar Signed-off-by: Björn Bergman <bjorn.bergman@iar.com>
bjorniuppsala
force-pushed
the
last_section_for_cmake_linker_gen
branch
from
8ae871a to
06bc457
Compare
|
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
|
In the current state it works. Except in a corner case for iar (which will be fixed elsewhere). So please, review and if approriate, approve |
tejlmand
approved these changes
May 16, 2025
|
Any reviews or comments would be highly appreciated |
RobinKastberg
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake linker generator things for .last_section for cmake linker generator.
Follow up to #88970. Fixes bug #89719, for gcc/ld not for iar (yet)
This has been checked as described in the bug:
west -v build -p -b qemu_cortex_m3 /workdir/zephyr_iar-mn/tests/kernel/threads/thread_apis -- -DZEPHYR_TOOLCHAIN_VARIANT=zephyr -DCONFIG_CMAKE_LINKER_GENERATOR=y -DCONFIG_LINKER_LAST_SECTION_ID=y
Comparing the map-files with and without CONFIG_CMAKE_LINKER_GENERATOR.