driver: sensor: aosong,dht: fix sensor protocol

[moosery]

Fix DHT sensor protocol broken since previous change

A recent change 9eeb60c for issue #83192 improperly removed a critical line in the driver.
This commit replaces that line and moves an irq_lock to above any pin
value manipulation since the timing is critical in the DHT protocol.

This was tested with both IRQs enabled and disabled on an Arduino Giga R1 using a DHT11.

Fixes #89631

Signed-off-by: John Shelton moosery@gmail.com

[github-actions]

Hello @moosery, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

[moosery]

@OmarNaffaa can you please check this with your board setup? Remember to enable the IRQ locks in your prj.conf and use GPIO_ACTIVE_LOW on your GPIO pin. DHT's also require either a MCU pullup (like GPIO_PULL_UP) or a pull up resistor on the data line.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[OmarNaffaa]

I was able to poll with a DHT22 every second for ~1 hour with these changes if I disable WiFi on my device, but with WiFi on I immediately get a -5 error code when trying to fetch.

Since it does work with WiFi off on my board I think your fix is valid, but I would likely need to do some digging on my end to know more (maybe I'm doing something wrong on my project).

[moosery]

I've tested the driver with DHT11's and DHT22's on the ESP32-Wrover, NXP MIMXRT1060-EVKB, and the Arduino Giga R1. It has executed without fail for days.

However, there is some timing issue on that ESP32-Wrover board in regards to using wifi along with the DHT's (I am able to duplicate the issue that @OmarNaffaa sees when using wifi but only on the ESP32-Wrover).

I believe we need to go ahead and accept this pull request to get the driver back to working for other boards, and continue to work on figuring out what is causing the problem when wifi is enabled on a separate issue.

[moosery]

@MaureenHelm this PR has kind of stalled. Is it possible to get it moving again?

[github-actions]

Hi @moosery!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁