tests/c_lib: Skip double sqrt test when double is not 64 bits #89790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aescolar,
cfriedt,
nashif and
stephanosio
aescolar
reviewed
May 12, 2025
| @@ -147,6 +149,9 @@ int32_t *p_root_squared = (int32_t *)&root_squared; | |||
|
|
|||
| ZTEST(libc_common, test_sqrt) | |||
| { | |||
| #if __SIZEOF_DOUBLE__ != 8 | |||
| TC_PRINT("test_sqrt skipped, double not 64 bits\n"); | |||
There was a problem hiding this comment.
Should this call ztest_test_skip?
There was a problem hiding this comment.
Yup, thanks.
nashif
requested changes
May 12, 2025
keith-packard
force-pushed
the
skip-double-sqrt
branch
from
a9df1ab to
92b2cd0
Compare
aescolar
previously approved these changes
May 12, 2025
keith-packard
force-pushed
the
skip-double-sqrt
branch
from
92b2cd0 to
19df634
Compare
cfriedt
previously approved these changes
May 12, 2025
|
@keith-packard note the compliance check failure |
keith-packard
force-pushed
the
skip-double-sqrt
branch
from
19df634 to
f9c8679
Compare
nashif
previously approved these changes
May 12, 2025
cfriedt
previously approved these changes
May 12, 2025
aescolar
previously approved these changes
May 13, 2025
|
@keith-packard an older version of this commit got in thru #90398. |
oops. yeah, this one is probably nicer. |
This test only works for 64-bit values. On targets which use 32 bits for double, skip this version. The float test will check the 32-bit math for that. This is the 'nicer' version of this fix which uses sizeof rather than relying on __SIZEOF_DOUBLE__. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
dismissed stale reviews from aescolar, cfriedt, and nashif
via
e03fcc8
keith-packard
force-pushed
the
skip-double-sqrt
branch
from
f9c8679 to
e03fcc8
Compare
nashif
approved these changes
May 26, 2025
|
cfriedt
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test only works for 64-bit values. On targets which use 32 bits for double, skip this version. The float test will check the 32-bit math for that.