modules: uoscore/uedhoc: fix PSA Crypto dependencies selection #90341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
valeriosetti
commented
May 22, 2025
valeriosetti
commented
- Remove selection of RSA crypto support because uoscore/uedhoc only use EC keys, not RSA ones
- Instead of having uoscore/uedhoc dependencies all over the Mbed TLS' Kconfig move the selection of required PSA Crypto features in uoscore-uedhoc's Kconfig
uOSCORE and uEDHOC only use ECDSA and ECDH for signatures and key agreement respectively, so the support for RSA is not required. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
github-actions
bot
requested review from
ceolin,
d3zd3z,
ithinuel,
rlubos and
wearyzen
tomi-font
requested changes
May 26, 2025
modules/uoscore-uedhoc/Kconfig
Outdated
| select PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_IMPORT | ||
| select PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_EXPORT | ||
| select PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_GENERATE | ||
| # select PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_DERIVE |
Let uOSCORE and uEDHOC Kconfigs select required PSA Crypto features instead of having them selected in Mbed TLS' Kconfigs. Besides this the previous configuration was enabling legacy support in Mbed TLS whereas uOSCORE/uEDHOC use PSA Crypto APIs. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
PSA Crypto dependencies are automatically selected in the uOSCORE's Kconfig. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
valeriosetti
force-pushed
the
uoscore-uedhoc-rework
branch
from
7494511 to
a6ff67a
Compare
|
tomi-font
approved these changes
May 27, 2025
rlubos
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.