Support StickC-Plus2 #90448
Support StickC-Plus2 #90448
Conversation
|
Hello @letanphuc, and thank you very much for your first pull request to the Zephyr project! |
github-actions
bot
requested review from
danieldegrasse,
JarmouniA,
jfischer-no and
VynDragon
|
Hello, Thank you. For supply pin, do not modify the display driver since this is specific to this board, instead, add a CMakelists.txt and relevant code in your board's folder. |
letanphuc
force-pushed
the
main
branch
2 times, most recently
from
355b71a to
3da3203
Compare
|
From my view point, the pin is belong to the display. If we do not use the display, I do not want to turn the pin on anyway. |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
Hello, thank you for your work! |
| @@ -411,6 +412,15 @@ static int st7789v_init(const struct device *dev) | |||
| } | |||
|
|
|||
| k_sleep(K_TIMEOUT_ABS_MS(config->ready_time_ms)); | |||
|
|
|||
| if (config->supply_gpio.port) { | |||
There was a problem hiding this comment.
This isn't the display's driver, it's the panel controller's driver, so pins should not be dealt with here.
| full_name: M5StickC PLUS2 | ||
| vendor: m5stack | ||
| socs: | ||
| - name: esp32 |
There was a problem hiding this comment.
shouldn't this be esp32_pico_d4?
|
|
||
| / { | ||
| model = "M5StickC Plus APPCPU"; | ||
| compatible = "espressif,esp32"; |
There was a problem hiding this comment.
this is the board's compatible
| compatible = "espressif,esp32"; | |
| compatible = "m5stack,m5stickc_plus2"; |
| @@ -0,0 +1,30 @@ | |||
| /* | |||
| * Copyright (c) 2023 Espressif Systems (Shanghai) Co., Ltd. | |||
There was a problem hiding this comment.
put your own copyright everywhere
| supported: | ||
| - uart | ||
| testing: | ||
| ignore_tags: |
| Sysbuild | ||
| ======== | ||
|
|
||
| The sysbuild makes possible to build and flash all necessary images needed to |
There was a problem hiding this comment.
| The sysbuild makes possible to build and flash all necessary images needed to | |
| The sysbuild makes it possible to build and flash all necessary images needed to |
| The sysbuild makes possible to build and flash all necessary images needed to | ||
| bootstrap the board with the ESP32 SoC. | ||
|
|
||
| To build the sample application using sysbuild use the command: |
There was a problem hiding this comment.
| To build the sample application using sysbuild use the command: | |
| To build the sample application using sysbuild, use the command: |
|
|
||
| .. note:: | ||
|
|
||
| With ``--sysbuild`` option the bootloader will be re-build and re-flash |
There was a problem hiding this comment.
| With ``--sysbuild`` option the bootloader will be re-build and re-flash | |
| With ``--sysbuild`` option the bootloader will be re-built and re-flashed |
| Manual build | ||
| ============ | ||
|
|
||
| During the development cycle, it is intended to build & flash as quickly possible. |
There was a problem hiding this comment.
| During the development cycle, it is intended to build & flash as quickly possible. | |
| During the development cycle, it is intended to build & flash as quickly as possible. |
|
|
||
| .. note:: | ||
|
|
||
| Remember that bootloader (MCUboot) needs to be flash at least once. |
There was a problem hiding this comment.
| Remember that bootloader (MCUboot) needs to be flash at least once. | |
| Remember that bootloader (MCUboot) needs to be flashed at least once. |
|
Commits need squashing, merge commits need removing |
Support StickC-Plus2
![Uploading image.png…]()
https://docs.m5stack.com/en/core/M5StickC%20PLUS2
Anything works well for now.
Build with board name is
m5stickc_plus2