drivers: can: mcp2515: various code quality fixes #90593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
henrikbrixandersen
commented
May 26, 2025
henrikbrixandersen
commented
- Declare the variable "data_idx" inside the loops to limit it's scope.
- Terminate the if...else if construct with an else block in order to adhere to coding guidelines.
- Merge two nested if-statements into one.
- Reformat the MCP2515 driver files using clang-format and remove excessive newlines between variable declarations.
Declare the variable "data_idx" inside the loops to limit it's scope. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Terminate the if...else if construct with an else block in order to adhere to coding guidelines. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Merge two nested if-statements into one. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Reformat the MCP2515 driver files using clang-format and remove excessive newlines between variable declarations. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
henrikbrixandersen
force-pushed
the
can_mcp2515_sonarqube_fixes
branch
from
628bc96 to
30967a7
Compare
|
github-actions
bot
requested review from
alexanderwachter,
martinjaeger and
str4t0m
|
@alexanderwachter, @martinjaeger, @str4t0m: Please review. |
martinjaeger
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.