Skip to content

RFC: Bluetooth: Controller: Introduce LL_ASSERT_DBG/ERR #90599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RFC: Bluetooth: Controller: Introduce LL_ASSERT_DBG/ERR #90599

wants to merge 2 commits into from
+986 −964

Conversation

cvinayak
Copy link
Collaborator

@cvinayak cvinayak commented May 26, 2025 •
edited
Loading

Introduce development and fatal assertion classification in the Controller implementation.

hci_ipc for nRF5340 Audio DK with nRF21540 FEM:

cmake -GNinja -DBOARD=nrf5340_audio_dk/nrf5340/cpunet -DCONF_FILE="nrf5340_cpunet_iso-bt_ll_sw_split.conf" -DEXTRA_CONF_FILE="overlay-nrf5340_cpunet_iso_nrf21540_ek-bt_ll_sw_split.conf" -DDTC_OVERLAY_FILE="boards/nrf5340_audio_dk_nrf5340_cpunet_nrf21540_ek.overlay" -DSNIPPET="bt-ll-sw-split" ../../samples/bluetooth/hci_ipc

Current memory:

Memory region         Used Size  Region Size  %age Used
           FLASH:      243304 B       256 KB     92.81%
             RAM:       64036 B        64 KB     97.71%
           SRAM1:          0 GB        64 KB      0.00%
        IDT_LIST:          0 GB        32 KB      0.00%

Memort when Debug Assertions disabled (still not all assertion converted though):

Memory region         Used Size  Region Size  %age Used
           FLASH:      228208 B       256 KB     87.05%
             RAM:       64036 B        64 KB     97.71%
           SRAM1:          0 GB        64 KB      0.00%
        IDT_LIST:          0 GB        32 KB      0.00%

15KB or ~ 6% reduction in code size.

@cvinayak cvinayak force-pushed the github_ll_assert_dbg branch 4 times, most recently from d9e0e27 to 4ff5213 Compare May 26, 2025 18:57
@cvinayak cvinayak mentioned this pull request May 27, 2025
Merged
@cvinayak cvinayak changed the title Bluetooth: Controller: Introduce LL_ASSERT_DBG/ERR RFC: Bluetooth: Controller: Introduce LL_ASSERT_DBG/ERR Jun 5, 2025
@cvinayak cvinayak marked this pull request as ready for review June 5, 2025 13:17
cvinayak added 2 commits June 5, 2025 15:20
@cvinayak
Bluetooth: Controller: Introduce LL_ASSERT_DBG/ERR
1d59737 
Introduce development and fatal assertion classification
in the Controller implementation.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: Controller: Disable LL_ASSERT_DBG
61f7bbb 
Disable LL_ASSERT_DBG.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak force-pushed the github_ll_assert_dbg branch from 4ff5213 to 61f7bbb Compare June 5, 2025 13:21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

Quality Gate Passed Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.5% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlescufi carlescufi

@erbr-ot erbr-ot

@thoh-ot thoh-ot

@Tronil Tronil

@wopu-ot wopu-ot

At least 2 approving reviews are required to merge this pull request.

Assignees

@cvinayak cvinayak

Labels
area: Bluetooth Controller area: Bluetooth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cvinayak