Skip to content

ST DTS lint #90611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yishai1999
Copy link
Collaborator

Fixed two issues according to the device tree guidelines https://docs.kernel.org/devicetree/bindings/dts-coding-style.html:

  1. The reg property should be second only to the compatible property within a node. This was not the case in many partition nodes definitions.
  2. The status property should be the last property in a node.

Copy link
Collaborator

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed these changes are recommended.
A few review comments.

According to the guidelines the `reg` property should always come before
any other property other than `compatible`.

Link: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
Signed-off-by: Yishai Jaffe <yishai1999@gmail.com>
According to the guidelines the `status` property should always be the
last property listed.

Link: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
Signed-off-by: Yishai Jaffe <yishai1999@gmail.com>
Copy link

@yishai1999
Copy link
Collaborator Author

@etienne-lms All good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants