dts: arm64: ti: ti_am62x_a53: Add MAIN_I2C* #90637
Conversation
github-actions
bot
added
platform: TI K3
github-actions
bot
requested review from
carlocaione,
con-pax,
dnltz,
glneo,
gramsay0,
ithinuel,
jadonk,
JiafeiPan,
npitre,
povergoing,
SgrrZhf,
teburd,
vaishnavachath and
wearyzen
| @@ -14,4 +14,14 @@ | |||
| main_uart6_tx_default: main_uart6_tx_default { | |||
| pinmux = <K3_PINMUX(0x0020, PIN_OUTPUT, MUX_MODE_3)>; | |||
| }; | |||
|
|
|||
| P1_26_i2c_default: P1_26_i2c_default { | |||
There was a problem hiding this comment.
What is P1_26? This should be main_i2c2_sda_default.
There was a problem hiding this comment.
Well, it is supposed to be the header numbering followed in pocketbeagle. However, it does seem like main_i2c2 cannot be pimuxed to other header header pins, so I am using main_i2c2_{sda/scl}_default now
Ayush1325
force-pushed
the
pb2-a53-i2c-upstream
branch
from
d8fb3f0 to
708f1a1
Compare
Ayush1325
force-pushed
the
pb2-a53-i2c-upstream
branch
from
708f1a1 to
8da4e79
Compare
| @@ -31,28 +31,28 @@ LOG_MODULE_REGISTER(omap_i2c, CONFIG_I2C_LOG_LEVEL); | |||
| typedef struct { | |||
| uint8_t RESERVED_0[0x10]; /**< Reserved, offset: 0x0 */ | |||
|
|
|||
| __IO uint32_t SYSC; /**< System Configuration, offset: 0x10 */ | |||
There was a problem hiding this comment.
Not sure what this __IO was or where it came from, but I'm guessing it was defined as volatile somewhere. Thinking on that, anywhere i2c_omap_regs_t is used it will need to be volatile, maybe putting that in the DEV_I2C_BASE definition will help enforce that.
There was a problem hiding this comment.
I have made all uses of DEV_I2C_BASE volatile. This is similar to what is being done in gpio-davinic driver.
Add all main domain i2cs. Also using the naming scheme from linux kernel to use the domain prefix in nodes. It would be best if the naming scheme is followed for all new additions. I will create PRs to migrate the already defined nodes to the prefix based naming scheme in the future. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Remove __IO macro. Fix build errors for PocketBeagle 2 A53 target Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Add pimux for I2C on pins P1.26 and P1.28 Signed-off-by: Ayush Singh <ayush@beagleboard.org>
- Pins P1.26 and P1.28 Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Ayush1325
force-pushed
the
pb2-a53-i2c-upstream
branch
from
a66141d to
0a3b195
Compare
|
Not sure why that job failed. Maybe something is wrong with the runners. |
Since the __IO macro use has been removed, make the whole reg pointer volatile. This is similar to what is done in the gpio-davinci driver. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Ayush1325
force-pushed
the
pb2-a53-i2c-upstream
branch
from
0a3b195 to
d6b6409
Compare
|
Using the node naming scheme from linux kernel to use the domain prefix in nodes. It would be best if the naming scheme is followed for all new additions.
I will create PRs to migrate the already defined nodes to the prefix based naming scheme in the future.
Tested on Pocket Beagle 2