Skip to content

riscv: remove unused function warnings #90664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

riscv: remove unused function warnings #90664

merged 2 commits into from
Jun 2, 2025

Conversation

niedzwiecki-dawid
Copy link
Member

Modify files that generate unused functions warnings.

@github-actions github-actions bot added area: Interrupt Controller area: RISCV RISCV Architecture (32-bit & 64-bit) labels May 27, 2025
@fkokosinski
Copy link
Member

Hey, thanks for this PR!

Could you guard those symbols with ifdefs instead, so that they're not defined when not needed instead?

@niedzwiecki-dawid
Copy link
Member Author

Hey, thanks for this PR!

Could you guard those symbols with ifdefs instead, so that they're not defined when not needed instead?

Done.

@ycsin
Copy link
Member

ycsin commented May 28, 2025

Hey, thanks for this PR!
Could you guard those symbols with ifdefs instead, so that they're not defined when not needed instead?

Done.

The message of the first commit has to be updated

@niedzwiecki-dawid
arch: riscv: guard some funcions
ed774cd 
Guard some functions with ifdefs to avoid unused function
compilation errors.

Signed-off-by: Dawid Niedzwiecki <dawidn@google.com>
@niedzwiecki-dawid
interrupt_controller: intc_plic: move unused function
df3696c 
Move function that is used only if some configs are defined.

Signed-off-by: Dawid Niedzwiecki <dawidn@google.com>
@niedzwiecki-dawid
Copy link
Member Author

Hey, thanks for this PR!
Could you guard those symbols with ifdefs instead, so that they're not defined when not needed instead?

Done.

The message of the first commit has to be updated

Done

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kartben kartben merged commit 964aa56 into zephyrproject-rtos:main Jun 2, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycsin ycsin

@fkokosinski fkokosinski

@carlocaione carlocaione

@edersondisouza edersondisouza

@katsuster katsuster

@kgugala kgugala

@mgielda mgielda

@npitre npitre

@tgorochowik tgorochowik

@VynDragon VynDragon

Assignees

@kgugala kgugala

@tgorochowik tgorochowik

@fkokosinski fkokosinski

Labels
area: Interrupt Controller area: RISCV RISCV Architecture (32-bit & 64-bit)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@niedzwiecki-dawid @fkokosinski @ycsin @kartben @kgugala @tgorochowik