drivers: can: rcar: various code quality fixes #90694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
henrikbrixandersen
commented
May 27, 2025
henrikbrixandersen
commented
- Always initialize the return value variable to avoid returning garbage.
- Declare the loop condition variable inside the loops to limit their scope.
- Merge two nested if-statements into one.
Always initialize the return value variable to avoid returning garbage. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
…oops Declare the loop condition variable inside the loops to limit their scope. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Merge two nested if-statements into one. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
henrikbrixandersen
added
area: CAN
Trivial
github-actions
bot
requested review from
aaillet,
alexanderwachter,
lorc,
martinjaeger,
str4t0m and
xakep-amatop
|
kartben
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.