samples: counter: alarm: fix CI build fail #90709
Conversation
github-actions
bot
added
size: XS
thenguyenyf
force-pushed
the
sample_counter_alarm_fix_CI
branch
2 times, most recently
from
5d1282a to
c1d177b
Compare
|
Hello @butok . I created a PR to exclude the mimxrt1060_evk from counter/alarm build. But I think it is better to add an overlay for mimxrt1060_evk to enable this sample like this https://github.com/zephyrproject-rtos/zephyr/blob/f432d5d510ae7f496e0254f7eb431bc96f10a7f5/tests/drivers/counter/counter_basic_api/boards/mimxrt1060_evk_mimxrt1062_qspi.overlay. |
| - mimxrt1060_evk@A/mimxrt1062/qspi | ||
| - mimxrt1060_evk@B/mimxrt1062/qspi | ||
| - mimxrt1060_evk@C/mimxrt1062/hyperflash | ||
| - mimxrt1060_evk@C/mimxrt1062/qspi |
There was a problem hiding this comment.
Guess, it's enough to have it without a revision to cover all possible variants:
- mimxrt1060_evk/mimxrt1062/hyperflash
- mimxrt1060_evk/mimxrt1062/qspi
There was a problem hiding this comment.
I'm not really familiar with this. But it seems the twister does not depend on the board.yml, just using the test identifier in mimxrt1060_evk_mimxrt1062_qspi_C.yaml. I applied your suggestion but it does not work.
There was a problem hiding this comment.
I'm not really familiar with this. But it seems the twister does not depend on the
board.yml, just using the test identifier inmimxrt1060_evk_mimxrt1062_qspi_C.yaml. I applied your suggestion but it does not work.
Hm, strange twister. It means we need to list all combinations for all available revisions.
I agree, this is a gap. We need to add the samples/counter support for NXP platforms. And we definitely will do it later. ;) |
|
Hi @thenguyenyf, please fix the merge conflict to make it mergeable. |
Exclude mimxrt1060_evk from build as this board does not support this sample yet Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
thenguyenyf
force-pushed
the
sample_counter_alarm_fix_CI
branch
from
c1d177b to
fcb0fd7
Compare
|
Exclude mimxrt1060_evk from build as this board
does not support this sample yet
Signed-off-by: The Nguyen the.nguyen.yf@renesas.com