Skip to content

boards: raspberrypi: rpi_pico: Include default partitions #90758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlbwoods
Copy link
Contributor

@jlbwoods jlbwoods commented May 28, 2025

Include sysbuild 2M partitions for rpi_pico boards; and
choose to use the slot0_partition as the code-partition.

@github-actions github-actions bot added platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) size: XS A PR changing only a single line of code labels May 28, 2025
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#90758 (comment)

#90758 (comment)

There are no other issues besides this one from me.

I will approve it as soon as it is fixed.

@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch from ab507c1 to 90d4914 Compare May 29, 2025 15:47
@jlbwoods jlbwoods requested review from nordicjm and soburi May 29, 2025 15:47
@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch 3 times, most recently from 7abaf66 to 0fbd0b3 Compare May 29, 2025 16:44
soburi
soburi previously approved these changes May 29, 2025
@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch from 0fbd0b3 to d10c844 Compare May 31, 2025 16:59
@jlbwoods
Copy link
Contributor Author

jlbwoods commented Jun 2, 2025

What's the next step to get this merged?

@soburi
Copy link
Member

soburi commented Jun 2, 2025

@nordicjm
Can you take a look again please?

Include sysbuild 2M partitions for rpi_pico boards; and
choose to use the slot0_partition as the code-partition.

Signed-off-by: John Lin <john.lin@beechwoods.com>
@jlbwoods jlbwoods force-pushed the pr_boards_raspberrypi_rpi_pico branch from d10c844 to 602e7f3 Compare June 4, 2025 00:03
Copy link

sonarqubecloud bot commented Jun 4, 2025

@soburi
Copy link
Member

soburi commented Jun 4, 2025

@jlbwoods

I don't think no need to make sysbuild as default, is there a reason for the change?

@jlbwoods
Copy link
Contributor Author

jlbwoods commented Jun 4, 2025

@jlbwoods

I don't think no need to make sysbuild as default, is there a reason for the change?

True. Will revert the changes and use storage partitions as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants