Fix LTO & -O2 offset out of range #90865
Open
+33
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bbolen,
carlocaione,
galak,
ithinuel,
MaureenHelm,
microbuilder,
stephanosio and
wearyzen
The arch.shared_interrupt.lto.speed compile fail on apollo5 platform. Remove ldr instruction and pass function pointer by register. Signed-off-by: Swift Tian <swift.tian@ambiq.com>
|
|
This wouldn’t work for platform that can take only two input operands… Any suggestion on making the two function pointer less PC relative so it doesn’t exceed ldr offset? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arch.shared_interrupt.lto.speed compile fail on apollo5 platform.
Remove ldr instruction and pass function pointer by input operand.
This PR could fix #90777.