soc: npcx: Add __packed to flags struct in npcx_pinctrl #90888
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with clang and CONFIG_LTO, clang warns:
soc/nuvoton/npcx/common/pinctrl_soc.h:141:4: error: field flags within
'struct npcx_pinctrl' is less aligned than 'struct (unnamed struct at
soc/nuvoton/npcx/common/./pinctrl_soc.h:128:2)' and is usually due to
'struct npcx_pinctrl' being packed, which can lead to unaligned accesses
[-Werror,-Wunaligned-access]
} flags;
^
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
force-pushed
the
push-rnsonptmzqnp
branch
from
ebac607 to
a9c99d7
Compare
thughes
changed the title
|
github-actions
bot
added
platform: Nuvoton NPCX
github-actions
bot
requested review from
alvsun,
ChiHuaL,
fabiobaltieri,
jackrosenthal,
keith-zephyr,
MulinChao,
sjg20 and
TomChang19
keith-zephyr
approved these changes
May 30, 2025
fabiobaltieri
approved these changes
May 30, 2025
fabiobaltieri
added
the
Trivial
|
@MulinChao @ChiHuaL I need one of you to approve this in order for it to be merged. Thanks! |
ChiHuaL
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with clang and CONFIG_LTO, clang warns: