cmake: compiler: Remove -fshort-enums #90889
Open
+0
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"-fshort-enums" changes the ABI. It's not enabled for gcc, so it's not clear why it's enabled for clang (only ARM) and armclang, other than it looks like some users of these toolchains may be linking against code that is compiled with "-fshort-enums". As an example, when compiling with clang, CONFIG_LTO, and a toolchain built without "-fshort-enums", the linker warns: ld.lld: error: linking module flags 'min_enum_size': IDs have conflicting values in '/usr/armv7m-cros-eabi/usr/lib/libc++_static.a(string.cpp.o at 784090)' and 'ld-temp.o' Signed-off-by: Tom Hughes <tomhughes@chromium.org>
|
I think we should put |
|
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
|
@tejlmand Thoughts? |
keith-zephyr
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"-fshort-enums" changes the ABI. It's not enabled for gcc, so it's not
clear why it's enabled for clang (only ARM) and armclang, other than it
looks like some users of these toolchains may be linking against code
that is compiled with "-fshort-enums".
As an example, when compiling with clang, CONFIG_LTO, and a toolchain
built without "-fshort-enums", the linker warns:
ld.lld: error: linking module flags 'min_enum_size': IDs have
conflicting values in
'/usr/armv7m-cros-eabi/usr/lib/libc++_static.a(string.cpp.o at 784090)'
and 'ld-temp.o'