Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RND-2311: enums for server url in openapi block #2452

Closed
wants to merge 66 commits into from

Conversation

BrettJephson
Copy link
Contributor

@BrettJephson BrettJephson commented Sep 5, 2024

With this PR, open api schemas with an array of servers and variables for server urls will allow selection of the variables and choice of server.

Updating code samples and scalar modal's server url when updated. Which fixes Issue #2432

CleanShot.2024-09-12.at.17.11.32.mp4

Copy link

linear bot commented Sep 5, 2024

@BrettJephson BrettJephson self-assigned this Sep 5, 2024
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: d9ee1a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gitbook/react-openapi Minor
gitbook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 5, 2024 12:53 Inactive
@BrettJephson BrettJephson force-pushed the brett/RND-2311-openapi-enum branch from be799b1 to c84cf3d Compare September 5, 2024 12:54
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 5, 2024 12:57 Inactive
Copy link

argos-ci bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 24 changed Dec 31, 2024, 11:13 PM

@BrettJephson BrettJephson force-pushed the brett/RND-2311-openapi-enum branch from c84cf3d to cde6f2e Compare September 12, 2024 15:46
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 12, 2024 15:49 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 12, 2024 15:51 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 12, 2024 16:01 Inactive
@BrettJephson BrettJephson marked this pull request as ready for review September 12, 2024 16:09
@BrettJephson BrettJephson changed the title RND-2311: surfacing enums for server url in openapi RND-2311: enums for server url in openapi block Sep 12, 2024
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 13, 2024 08:33 Inactive
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick first pass, I think we should abstract the concept of enum you are introducing here (enum is also a confusing name btw), to also be used for other client states that the block needs.

@BrettJephson BrettJephson force-pushed the brett/RND-2311-openapi-enum branch from ec4c412 to d28d46b Compare September 20, 2024 10:28
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 20, 2024 10:36 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 20, 2024 10:44 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 23, 2024 07:20 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 23, 2024 13:18 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 24, 2024 10:10 Inactive
@BrettJephson BrettJephson force-pushed the brett/RND-2311-openapi-enum branch from 0d7e4b6 to 2b7ea27 Compare September 24, 2024 10:38
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 24, 2024 10:40 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 24, 2024 10:42 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 24, 2024 11:08 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) September 24, 2024 11:11 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 9, 2024 13:06 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 14, 2024 10:41 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 18, 2024 08:59 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 21, 2024 18:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Test it" tool URL not prepopulated with gitbook API and must be manually edited
2 participants