Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting go version from toolchain directive #557

Open
ahrtr opened this issue Feb 26, 2025 · 2 comments
Open

Support getting go version from toolchain directive #557

ahrtr opened this issue Feb 26, 2025 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@ahrtr
Copy link

ahrtr commented Feb 26, 2025

Based on the Getting go version from the go.mod file,

The go directive in go.mod can specify a patch version or omit it altogether (e.g., go 1.22.0 or go 1.22).
If a patch version is specified, that specific patch version will be used.
If no patch version is specified, it will search for the latest available patch version in the cache, 
versions-manifest.json, and the "official Go language website", in that order.

If the go directive doesn't specify a patch version, I think it should use the version specified in toolchain directive (i.e. toolchain go1.23.6) if present. If the toolchain isn't present at all, then you continue to search other options.

@priyagupta108
Copy link
Contributor

Hi @ahrtr 👋,
Thank you for the feature request, we will investigate it and get back to you as soon as we have some feedback.

@mattbnz
Copy link

mattbnz commented Feb 27, 2025

This seems like it duplicates the requests already being discussed in #457 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants