Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: @scope input should default to the scope specified in package.json #128

Open
jasonkarns opened this issue Mar 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jasonkarns
Copy link

As I've used the setup-node action in about a dozen projects now, I've consistently needed to set the scope input for the action. This seems redundant because this information is already present in the package.json in the name.

When this action is used to publish a node module to a registry, the scope must be the same as the one defined in the package's package.json. Information that must change together is precisely the kind of information that should be DRY. So I would hope that the scope input could be defaulted to the scope defined in the package.json automatically.

(The same should be true for the registry, as defined in package.json#publishConfig)

@jasonkarns
Copy link
Author

I wished for this behavior back in 2020 and I wish for it even more now.

It's quite frustrating to try and use setup-node in a reusable workflow, when the scope name must then be parameterized. This information already exists in the package.json. If this action would respect the scope from package.json, then there would be no need for an explicit scope parameter to the action. Which then means, setup-node could be more easily used in reusable workflows without needing to parameterize the workflow with redundant params.

deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@jasonkarns @bryanmacfarlane and others