Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv4 and IPv6 output in Armbian welcome MOTD #7911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

useful64
Copy link
Contributor

@useful64 useful64 commented Mar 5, 2025

Description

Now "Armbian welcome MOTD" only prints one LAN IPv4 address and does not print any IPv6 address if you have more than one.

I changed to print all IPv4 and IPv6 addresses. I also made some cosmetic changes (based on .editorconfig from this repository).

How Has This Been Tested?

  • On dev machine.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@useful64 useful64 requested a review from a team as a code owner March 5, 2025 01:14
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review BSP Board Support Packages labels Mar 5, 2025
@igorpecovnik
Copy link
Member

Thank you for addressing this problem. Current way is not the best and we also have a Jira ticket on the topic. https://armbian.atlassian.net/browse/AR-2571

I tried changed script and few of our production servers:
image

What stand out is:

  • ipv6 management. WAN ipv6 is among all and in the (Outgoing WAN) section. Also there is probably very small need to display local IPV6 addresses?

The other example machine:

IPv4 addresses: (LAN) 100.100.100.100, XX.YYY.XX (WAN) 100.100.100.100
IPv6 addresses: (All) 2 x local, 2 x external (one from tailscale, other from ISP)

Here we also have unnecessary duplication. We need to shuffle the logic around a bit - space for displaying is very limited, so its important we try our best.

The other issue is cosmetic nature - aligning data into columns. Now, IP sticks out as label text is longer.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP Board Support Packages Needs review Seeking for review size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

2 participants