-
Notifications
You must be signed in to change notification settings - Fork 31
Fixes #113 add hook to pretty print code to show in diff in atlascode #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcellourbani great to see this PR. I may have missed something, but it doesn't look quite complete.
…-Add-hook-to-pretty-print-code-to-show-in-diff-in-atlascode
4777b70
to
d556aa9
Compare
@bwieger-atlassian-com my apologies, I did the fix almost immediately but forgot to push it |
…ow-in-diff-in-atlascode
@bwieger-atlassian-com I believe I resolved the changes required, but github doesn't seem to think so.
PS: the final result of this + abaplint is in 113: the ABAP language is case insensitive, so lots of irrelevant changes are shown unless both sides are formatted before being diffed Thank you |
comment above was from me, I didn't notice I was logged in with the work account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's ok now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hope it's ok now
…ow-in-diff-in-atlascode
Fixes / implements #113