Fixes #113 add hook to pretty print code to show in diff in atlascode

[marcellourbani]

Fixes / implements #113

[bwieger-atlassian-com]

Reviewing

[bwieger-atlassian-com]

@marcellourbani great to see this PR. I may have missed something, but it doesn't look quite complete.

[bwieger-atlassian-com]

I don't see where this is used.

[marcellourbani]

Same thing you did in commandContext.ts, I'll refactor.

in normalize.ts:

function setCommandContext(key: CommandContext | string, value: any) {
    return commands.executeCommand('setContext', key, value);
}

[bwieger-atlassian-com]

How is atlascode:IsNormalizerEnabled being set?

[marcellourbani]

in enableDiffNormalize, in normalize.ts:

const enableDiffNormalize = (e?: TextEditor) => {
    const relevant = e?.document.uri.scheme === 'atlascode.bbpr';
    const active = relevant && normalizers.some((n) => n.isRelevant(e.document.uri));
    setCommandContext(CommandContext.IsNormalizerEnabled, active);
};

normalizers are populated by calling the extension API, like in vscode-abaplint:

  if (ext.exports?.registerCodeNormalizer) {
    const norm = getAbapCodeNormalizer(client);
    integrationIsActive = (u) => u.scheme === ATLASCODEDIFF && norm.isRelevant(u);
    ext.exports.registerCodeNormalizer(norm);
  }

[marcellourbani]

It's set in enableDiffNormalize (see normalize.ts):

const enableDiffNormalize = (e?: TextEditor) => {
    const relevant = e?.document.uri.scheme === 'atlascode.bbpr';
    const active = relevant && normalizers.some((n) => n.isRelevant(e.document.uri));
    setCommandContext(CommandContext.IsNormalizerEnabled, active);
};

this only happens if a normalizer is registered, as for instance vscode-abaplint

  if (ext.exports?.registerCodeNormalizer) {
    const norm = getAbapCodeNormalizer(client);
    integrationIsActive = (u) => u.scheme === ATLASCODEDIFF && norm.isRelevant(u);
    ext.exports.registerCodeNormalizer(norm);
  }

[marcellourbani]

To explain better, I created a public repo with a PR here:

becomes:

abaplint always has the normalizer, but with this can be enabled by default, as normalization is run by bitbucket