Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading icon to summary panel #166

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

sinhaviraj
Copy link
Contributor

I have added a loading icon to the summary section which used to load the contents without any visual indication to the user. Now while the initial summary is loading the loading icon would be visible to the user.

Copy link

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution.
If your email is listed below, please ensure that you sign the CLA with the same email address.

The following users still need to sign our CLA:
❌sinhaviraj

Already signed the CLA? To re-check, try refreshing the page.

@sinhaviraj sinhaviraj requested a review from pastelsky March 4, 2025 06:26
@bwieger-atlassian-com
Copy link
Collaborator

Could you help us with a Loom video showing the user experience (not the code)?

And can you share the customer voice on this problem? Is there any quotes or data or industry best practices we can justify this change on?

@decompil3d
Copy link

@atlassian-cla-bot check

Copy link
Collaborator

@bwieger-atlassian-com bwieger-atlassian-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@decompil3d
Copy link

@atlassian-cla-bot check

@sinhaviraj
Copy link
Contributor Author

Could you help us with a Loom video showing the user experience (not the code)?

And can you share the customer voice on this problem? Is there any quotes or data or industry best practices we can justify this change on?

@bwieger-atlassian-com Here is the loom video https://www.loom.com/share/861a72679327419087cfaafc6972387f

I don't have a customer problem. I saw this as an opportunity for my first PR to improve the loading experience of summary section while viewing PR details. All other sections did have loading icons whereas for summary it used to load suddenly without any feedback to the user. This is why I felt maybe we should get this going.

@bwieger-atlassian-com
Copy link
Collaborator

@sinhaviraj The customer problem can be your own voice as well. Or a reference to an industry best practice.

Example:

As a user who clicks on a button with a long load time, I would like to see a visual indicator that my click is registered and something is happening.

The button for checking out a source branch on a PR takes a long time to load. So adding a loading state here so our customers are not confused.

Copy link
Collaborator

@bwieger-atlassian-com bwieger-atlassian-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinhaviraj sinhaviraj merged commit 940baa2 into atlassian:main Mar 7, 2025
1 check passed
@sinhaviraj sinhaviraj deleted the vs/add-loading-icon-summary branch March 7, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants