-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading icon to summary panel #166
Add loading icon to summary panel #166
Conversation
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
Could you help us with a Loom video showing the user experience (not the code)? And can you share the customer voice on this problem? Is there any quotes or data or industry best practices we can justify this change on? |
@atlassian-cla-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
@atlassian-cla-bot check |
@bwieger-atlassian-com Here is the loom video https://www.loom.com/share/861a72679327419087cfaafc6972387f I don't have a customer problem. I saw this as an opportunity for my first PR to improve the loading experience of summary section while viewing PR details. All other sections did have loading icons whereas for summary it used to load suddenly without any feedback to the user. This is why I felt maybe we should get this going. |
@sinhaviraj The customer problem can be your own voice as well. Or a reference to an industry best practice. Example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a loading icon to the summary section which used to load the contents without any visual indication to the user. Now while the initial summary is loading the loading icon would be visible to the user.