Non blocking BBC conflicts and other APIs in getChangedFiles #167
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error in some APIs
sinhaviraj
requested review from
bwieger-atlassian-com,
sdzh-atlassian,
cabella-dot and
marcomura
as code owners
pastelsky
reviewed
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In huge repo we found that PR's with a big conflict data would open up with error
Error fetching pull requests details failedThis was due to BBC conflict API taking longer than 30seconds which would cause an Axios timeout.
I have added the API calls inside getChangedFiles method in try/catch blocks to avoid causing an error on UI and it would continue to load with lesser details. The subsequent data would anyways be fetched once different components in UI call API to get their respective data.
Loom Video - http://loom.com/share/b158448d881041c3b856ce97ad2866c0