Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non blocking BBC conflicts and other APIs in getChangedFiles #167

Closed

Conversation

sinhaviraj
Copy link
Contributor

@sinhaviraj sinhaviraj commented Mar 4, 2025

In huge repo we found that PR's with a big conflict data would open up with error Error fetching pull requests details failed
image
This was due to BBC conflict API taking longer than 30seconds which would cause an Axios timeout.
I have added the API calls inside getChangedFiles method in try/catch blocks to avoid causing an error on UI and it would continue to load with lesser details. The subsequent data would anyways be fetched once different components in UI call API to get their respective data.

Loom Video - http://loom.com/share/b158448d881041c3b856ce97ad2866c0

Copy link
Collaborator

@bwieger-atlassian-com bwieger-atlassian-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinhaviraj
Copy link
Contributor Author

This PR gets superseeded by PR -> #171. These changes will be included in the other PR hence closing this PR

@sinhaviraj sinhaviraj closed this Mar 7, 2025
@sinhaviraj sinhaviraj deleted the vs/non-blocking-pr-details branch March 7, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants