[AXON-202] Optimize Jira site resolution check at auth time #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomura
requested review from
bwieger-atlassian-com,
sdzh-atlassian and
cabella-dot
as code owners
cabella-dot
previously approved these changes
Mar 5, 2025
marcomura
commented
Mar 7, 2025
marcomura
commented
Mar 7, 2025
marcomura
changed the title
bwieger-atlassian-com
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Bug Found:
JQL doesn't update on status update any more.
https://www.loom.com/share/1629ca21ad4340648b8dd1afa522319e?sid=8a3efdfe-39c6-44f7-a35a-a5cfa82a36c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change,
JqlManagerwas performing a check on the site to verify that its schema contains aresolutionfield in order to construct the correct default JQL query for it.After the change, this check is performed at auth time and stored in the
DetailedSiteInfostructure in the newhasResolutionFieldfield.This allows retrieving the default query for a site in constant time, and retrieving the list of all default queries (one for every site) with no latency compared to the approach before.
This change includes a backfill function in
jqlManager.tsto handle the already-storedDetailedSiteInfostructures without the newhasResolutionFieldinitialized.Tested
√ Jira Cloud auth
√ Jira DC auth
√ BitBucket Cloud auth
Test plan
https://hello.atlassian.net/wiki/spaces/AIDO/pages/4962648247/3.4.13+-+Release+Test+Plan