Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove barrel files from services collection (part 3) #3780

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR is another in a series removing barrel files from across our application, in this PR we're removing them from services/repositoryToken, services/repoUploadToken, services/toast, services/toastNotification, services/tracking, and updating the relevant imports.

Ticket: codecov/engineering-team#3352

Notable Changes

  • Remove index from services/repositoryToken, services/repoUploadToken, services/toast, services/toastNotification, services/tracking
  • Update imports across app

Copy link

codecov bot commented Feb 26, 2025

Bundle Report

Changes will decrease total bundle size by 19.46kB (-0.16%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.1MB -11.81kB (-0.19%) ⬇️
gazebo-production-esm 6.18MB -7.64kB (-0.12%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -1 bytes 113.63kB -0.0%
assets/index-legacy.*.js 1 bytes 21.1kB 0.0%
assets/index-legacy.*.js 2.49kB 35.48kB 7.56% ⚠️
assets/index-legacy.*.js -7.51kB 32.99kB -18.54%
assets/vendor_react_router-legacy.*.js -6.8kB 30.18kB -18.38%

Files in assets/index-legacy.*.js:

  • ./src/pages/OwnerPage/OwnerPage.jsx → Total Size: 2.63kB
view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -1 bytes 124.94kB -0.0%
assets/index.*.js 1 bytes 22.37kB 0.0%
assets/index.*.js -4.9kB 37.03kB -11.69%
assets/index.*.js 6 bytes 638.81kB 0.0%
assets/index.*.js -216 bytes 41.94kB -0.51%
assets/vendor_react_router.*.js -2.53kB 35.23kB -6.7%

Files in assets/index.*.js:

  • ./src/pages/OwnerPage/OwnerPage.jsx → Total Size: 2.62kB

Files in assets/index.*.js:

  • ./src/App.tsx → Total Size: 8.75kB

  • ./src/pages/AccountSettings/tabs/OrgUploadToken/TokenlessSection/useSetUploadTokenRequired.tsx → Total Size: 2.71kB

  • ./src/layouts/BaseLayout/BaseLayout.tsx → Total Size: 3.41kB

  • ./src/layouts/ToastNotifications/NotificationItem.jsx → Total Size: 801 bytes

  • ./src/layouts/ToastNotifications/ToastNotifications.jsx → Total Size: 451 bytes

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (ba49650) to head (bd395ae).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3780   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14955    14955           
  Branches     4269     4269           
=======================================
  Hits        14767    14767           
  Misses        181      181           
  Partials        7        7           
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <ø> (ø)
...rc/layouts/ToastNotifications/NotificationItem.jsx 100.00% <ø> (ø)
.../layouts/ToastNotifications/ToastNotifications.jsx 100.00% <ø> (ø)
...tings/tabs/Admin/DetailsSection/DetailsSection.jsx 100.00% <ø> (ø)
...ings/tabs/OktaAccess/hooks/useUpdateOktaConfig.tsx 100.00% <ø> (ø)
...ken/TokenlessSection/useSetUploadTokenRequired.tsx 100.00% <ø> (ø)
...s/tabs/OrgUploadToken/useGenerateOrgUploadToken.ts 100.00% <ø> (ø)
...tings/tabs/Profile/NameEmailCard/NameEmailCard.jsx 100.00% <ø> (ø)
src/pages/OwnerPage/OwnerPage.jsx 96.87% <ø> (ø)
... and 19 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba49650...bd395ae. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3780   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14955    14955           
  Branches     4269     4261    -8     
=======================================
  Hits        14767    14767           
  Misses        181      181           
  Partials        7        7           
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <ø> (ø)
...rc/layouts/ToastNotifications/NotificationItem.jsx 100.00% <ø> (ø)
.../layouts/ToastNotifications/ToastNotifications.jsx 100.00% <ø> (ø)
...tings/tabs/Admin/DetailsSection/DetailsSection.jsx 100.00% <ø> (ø)
...ings/tabs/OktaAccess/hooks/useUpdateOktaConfig.tsx 100.00% <ø> (ø)
...ken/TokenlessSection/useSetUploadTokenRequired.tsx 100.00% <ø> (ø)
...s/tabs/OrgUploadToken/useGenerateOrgUploadToken.ts 100.00% <ø> (ø)
...tings/tabs/Profile/NameEmailCard/NameEmailCard.jsx 100.00% <ø> (ø)
src/pages/OwnerPage/OwnerPage.jsx 96.87% <ø> (ø)
... and 19 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba49650...bd395ae. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov-public-qa bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (ba49650) to head (bd395ae).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3780   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14955    14955           
  Branches     4269     4269           
=======================================
  Hits        14767    14767           
  Misses        181      181           
  Partials        7        7           
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <ø> (ø)
...rc/layouts/ToastNotifications/NotificationItem.jsx 100.00% <ø> (ø)
.../layouts/ToastNotifications/ToastNotifications.jsx 100.00% <ø> (ø)
...tings/tabs/Admin/DetailsSection/DetailsSection.jsx 100.00% <ø> (ø)
...ings/tabs/OktaAccess/hooks/useUpdateOktaConfig.tsx 100.00% <ø> (ø)
...ken/TokenlessSection/useSetUploadTokenRequired.tsx 100.00% <ø> (ø)
...s/tabs/OrgUploadToken/useGenerateOrgUploadToken.ts 100.00% <ø> (ø)
...tings/tabs/Profile/NameEmailCard/NameEmailCard.jsx 100.00% <ø> (ø)
src/pages/OwnerPage/OwnerPage.jsx 96.87% <ø> (ø)
... and 19 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba49650...bd395ae. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 26, 2025

Bundle Report

Changes will decrease total bundle size by 19.46kB (-0.16%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.1MB -11.81kB (-0.19%) ⬇️
gazebo-staging-esm 6.18MB -7.64kB (-0.12%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 1 bytes 21.1kB 0.0%
assets/index-legacy.*.js 2.49kB 35.48kB 7.56% ⚠️
assets/index-legacy.*.js 1.52kB 32.99kB 4.85%
assets/index-legacy.*.js -1 bytes 113.63kB -0.0%
assets/index-legacy.*.js -9.04kB 31.46kB -22.31%
assets/vendor_react_router-legacy.*.js -6.8kB 30.18kB -18.38%

Files in assets/index-legacy.*.js:

  • ./src/pages/OwnerPage/OwnerPage.jsx → Total Size: 2.63kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 1 bytes 22.37kB 0.0%
assets/index.*.js 3.62kB 37.03kB 10.83% ⚠️
assets/index.*.js 1.34kB 33.41kB 4.17%
assets/index.*.js -1 bytes 124.94kB -0.0%
assets/index.*.js 6 bytes 638.81kB 0.0%
assets/index.*.js -10.08kB 32.08kB -23.91%
assets/vendor_react_router.*.js -2.53kB 35.23kB -6.7%

Files in assets/index.*.js:

  • ./src/pages/OwnerPage/OwnerPage.jsx → Total Size: 2.62kB

Files in assets/index.*.js:

  • ./src/layouts/ToastNotifications/ToastNotifications.jsx → Total Size: 451 bytes

  • ./src/layouts/ToastNotifications/NotificationItem.jsx → Total Size: 801 bytes

  • ./src/layouts/BaseLayout/BaseLayout.tsx → Total Size: 3.41kB

  • ./src/pages/AccountSettings/tabs/OrgUploadToken/TokenlessSection/useSetUploadTokenRequired.tsx → Total Size: 2.71kB

  • ./src/App.tsx → Total Size: 8.75kB

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 26, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
c292d6b Wed, 26 Feb 2025 13:49:18 GMT Expired Expired
8d0388c Wed, 26 Feb 2025 14:06:46 GMT Expired Expired
4a0d5fe Wed, 26 Feb 2025 15:15:30 GMT Expired Expired
bd395ae Mon, 10 Mar 2025 10:42:24 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (9136ccd) to head (4a0d5fe).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3780   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         824      824           
  Lines       14786    14798   +12     
  Branches     4242     4249    +7     
=======================================
+ Hits        14597    14609   +12     
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <ø> (ø)
...rc/layouts/ToastNotifications/NotificationItem.jsx 100.00% <ø> (ø)
.../layouts/ToastNotifications/ToastNotifications.jsx 100.00% <ø> (ø)
...tings/tabs/Admin/DetailsSection/DetailsSection.jsx 100.00% <ø> (ø)
...ings/tabs/OktaAccess/hooks/useUpdateOktaConfig.tsx 100.00% <ø> (ø)
...ken/TokenlessSection/useSetUploadTokenRequired.tsx 100.00% <ø> (ø)
...s/tabs/OrgUploadToken/useGenerateOrgUploadToken.ts 100.00% <ø> (ø)
...tings/tabs/Profile/NameEmailCard/NameEmailCard.jsx 100.00% <ø> (ø)
src/pages/OwnerPage/OwnerPage.jsx 96.87% <ø> (ø)
... and 19 more

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.29% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.11% <ø> (+<0.01%) ⬆️
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9136ccd...4a0d5fe. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit dc63ffa Mar 10, 2025
54 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3352-chore-rm-barrel-file-services-repoTkn-repoUpTkn-toasts-tracking branch March 10, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants