Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update signIn paths to append extra redirect #3794

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the various uses of signIn in Gazebo, that will conditionally append a secondary to parameter that will after the user is redirect back to Codecov will redirect the user to that URL.

Closes: codecov/engineering-team#3458

Notable Changes

  • Update ProviderButton
  • Update LoginButton
  • Update SyncButton
  • Update tests

Copy link

codecov bot commented Mar 5, 2025

Bundle Report

Changes will increase total bundle size by 1.17kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.11MB 527 bytes (0.01%) ⬆️
gazebo-production-esm 6.18MB 644 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 366 bytes 4.4kB 9.06% ⚠️
assets/index-legacy.*.js -1 bytes 16.6kB -0.01%
assets/index-legacy.*.js 1 bytes 7.8kB 0.01%
assets/index-legacy.*.js -1 bytes 24.97kB -0.0%
assets/index-legacy.*.js 1 bytes 11.43kB 0.01%
assets/index-legacy.*.js 81 bytes 3.66kB 2.27%
assets/index-legacy.*.js 1 bytes 9.46kB 0.01%
assets/index-legacy.*.js 1 bytes 12.28kB 0.01%
assets/index-legacy.*.js 1 bytes 11.94kB 0.01%
assets/index-legacy.*.js 1 bytes 21.1kB 0.0%
assets/index-legacy.*.js 1 bytes 12.66kB 0.01%
assets/index-legacy.*.js 73 bytes 2.6kB 2.89%
assets/index-legacy.*.js 1 bytes 49.4kB 0.0%
assets/RawFileViewer-legacy.*.js -1 bytes 127.05kB -0.0%
assets/ReposTable-legacy.*.js 1 bytes 10.49kB 0.01%
assets/ConfigureCachedBundleModal-legacy.*.js 1 bytes 7.87kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

Files in assets/index-legacy.*.js:

  • ./src/pages/SyncProviderPage/SyncButton.tsx → Total Size: 1.33kB

Files in assets/index-legacy.*.js:

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.43kB
view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 1 bytes 12.33kB 0.01%
assets/index.*.js 6 bytes 9.58kB 0.06%
assets/index.*.js 94 bytes 3.68kB 2.62%
assets/index.*.js -1 bytes 16.89kB -0.01%
assets/index.*.js 1 bytes 12.48kB 0.01%
assets/index.*.js 1 bytes 13.62kB 0.01%
assets/index.*.js 1 bytes 22.37kB 0.0%
assets/index.*.js 1 bytes 7.8kB 0.01%
assets/index.*.js 1 bytes 12.42kB 0.01%
assets/index.*.js -5 bytes 5.86kB -0.09%
assets/index.*.js -1 bytes 27.48kB -0.0%
assets/index.*.js 446 bytes 4.59kB 10.75% ⚠️
assets/index.*.js 92 bytes 2.52kB 3.79%
assets/index.*.js 1 bytes 53.58kB 0.0%
assets/RawFileViewer.*.js -1 bytes 126.83kB -0.0%
assets/ReposTable.*.js 1 bytes 11.25kB 0.01%
assets/ConfigureCachedBundleModal.*.js 1 bytes 8.31kB 0.01%
assets/BenefitList.*.js 5 bytes 1.47kB 0.34%

Files in assets/index.*.js:

  • ./src/pages/SyncProviderPage/SyncButton.tsx → Total Size: 1.33kB

Files in assets/index.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

Files in assets/index.*.js:

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.43kB

@codecov-staging
Copy link

codecov-staging bot commented Mar 5, 2025

Bundle Report

Changes will increase total bundle size by 1.17kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB 527 bytes (0.01%) ⬆️
gazebo-staging-esm 6.18MB 644 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 1 bytes 22.37kB 0.0%
assets/index.*.js 1 bytes 12.42kB 0.01%
assets/index.*.js 94 bytes 3.68kB 2.62%
assets/index.*.js 6 bytes 9.58kB 0.06%
assets/index.*.js -5 bytes 5.86kB -0.09%
assets/index.*.js 1 bytes 13.62kB 0.01%
assets/index.*.js 1 bytes 53.58kB 0.0%
assets/index.*.js 1 bytes 7.8kB 0.01%
assets/index.*.js -1 bytes 27.48kB -0.0%
assets/index.*.js 1 bytes 12.33kB 0.01%
assets/index.*.js 1 bytes 12.48kB 0.01%
assets/index.*.js 446 bytes 4.59kB 10.75% ⚠️
assets/index.*.js 92 bytes 2.52kB 3.79%
assets/index.*.js -1 bytes 16.89kB -0.01%
assets/RawFileViewer.*.js -1 bytes 126.83kB -0.0%
assets/ReposTable.*.js 1 bytes 11.25kB 0.01%
assets/ConfigureCachedBundleModal.*.js 1 bytes 8.31kB 0.01%
assets/BenefitList.*.js 5 bytes 1.47kB 0.34%

Files in assets/index.*.js:

  • ./src/pages/SyncProviderPage/SyncButton.tsx → Total Size: 1.33kB

Files in assets/index.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

Files in assets/index.*.js:

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.43kB
view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 366 bytes 4.4kB 9.06% ⚠️
assets/index-legacy.*.js 1 bytes 21.1kB 0.0%
assets/index-legacy.*.js -1 bytes 16.6kB -0.01%
assets/index-legacy.*.js 1 bytes 11.43kB 0.01%
assets/index-legacy.*.js 81 bytes 3.66kB 2.27%
assets/index-legacy.*.js 1 bytes 49.4kB 0.0%
assets/index-legacy.*.js 1 bytes 9.46kB 0.01%
assets/index-legacy.*.js 1 bytes 7.8kB 0.01%
assets/index-legacy.*.js 1 bytes 12.28kB 0.01%
assets/index-legacy.*.js -1 bytes 24.97kB -0.0%
assets/index-legacy.*.js 1 bytes 11.94kB 0.01%
assets/index-legacy.*.js 1 bytes 12.66kB 0.01%
assets/index-legacy.*.js 73 bytes 2.6kB 2.89%
assets/RawFileViewer-legacy.*.js -1 bytes 127.05kB -0.0%
assets/ReposTable-legacy.*.js 1 bytes 10.49kB 0.01%
assets/ConfigureCachedBundleModal-legacy.*.js 1 bytes 7.87kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

Files in assets/index-legacy.*.js:

  • ./src/pages/SyncProviderPage/SyncButton.tsx → Total Size: 1.33kB

Files in assets/index-legacy.*.js:

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.43kB

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (dc63ffa) to head (e0a5b2c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   98.74%   98.73%   -0.01%     
==========================================
  Files         826      826              
  Lines       14955    14969      +14     
  Branches     4261     4272      +11     
==========================================
+ Hits        14767    14780      +13     
- Misses        181      182       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...nterpriseLandingPage/ProviderCard/ProviderCard.tsx 96.77% <100.00%> (-3.23%) ⬇️
src/pages/LoginPage/LoginButton.jsx 100.00% <100.00%> (ø)
src/pages/SyncProviderPage/SyncButton.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <100.00%> (-0.01%) ⬇️
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc63ffa...e0a5b2c. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   98.74%   98.73%   -0.01%     
==========================================
  Files         826      826              
  Lines       14955    14969      +14     
  Branches     4261     4272      +11     
==========================================
+ Hits        14767    14780      +13     
- Misses        181      182       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...nterpriseLandingPage/ProviderCard/ProviderCard.tsx 96.77% <100.00%> (-3.23%) ⬇️
src/pages/LoginPage/LoginButton.jsx 100.00% <100.00%> (ø)
src/pages/SyncProviderPage/SyncButton.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <100.00%> (-0.01%) ⬇️
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc63ffa...e0a5b2c. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov-public-qa bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (dc63ffa) to head (e0a5b2c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   98.74%   98.73%   -0.01%     
==========================================
  Files         826      826              
  Lines       14955    14969      +14     
  Branches     4261     4272      +11     
==========================================
+ Hits        14767    14780      +13     
- Misses        181      182       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...nterpriseLandingPage/ProviderCard/ProviderCard.tsx 96.77% <100.00%> (-3.23%) ⬇️
src/pages/LoginPage/LoginButton.jsx 100.00% <100.00%> (ø)
src/pages/SyncProviderPage/SyncButton.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <100.00%> (-0.01%) ⬇️
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc63ffa...e0a5b2c. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 5, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
640fce0 Wed, 05 Mar 2025 14:36:37 GMT Expired Expired
6dd623c Mon, 10 Mar 2025 10:55:56 GMT Expired Expired
e0a5b2c Mon, 10 Mar 2025 12:58:21 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit fa6e9b5 Mar 10, 2025
51 of 54 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3458-update-signIn-paths-to-pass-to-query-param branch March 10, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Update signIn paths to add redirect string to
3 participants