fix: pass impl_type arg to TA tasks instead of new_impl #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-sentry
force-pushed
the
joseph/update-upload
branch
from
0d97342 to
8a2baab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 97.78% 97.78% -0.01%
==========================================
Files 446 446
Lines 36782 36778 -4
==========================================
- Hits 35969 35965 -4
Misses 813 813
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
joseph-sentry
force-pushed
the
joseph/update-upload
branch
from
8a2baab to
99c37a9
Compare
joseph-sentry
force-pushed
the
joseph/update-upload
branch
from
99c37a9 to
2d9ca77
Compare
✅ Sentry found no issues in your recent changes ✅ |
impl_type is a literal that can be "old" | "new" | "both" old: in the case of old it will keep running the it has been both: it will run the timescale implementation of the TA proc task but it won't be updating the upload state or deleting/rewriting the raw upload new: it will only run the new timescale implementation and it will update the upload state and rewrite/delete the raw upload
joseph-sentry
force-pushed
the
joseph/update-upload
branch
from
2d9ca77 to
9acb97c
Compare
Swatinem
approved these changes
Mar 12, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl_type is a literal that can be "old" | "new" | "both"
old: in the case of old it will keep running the it has been
both: it will run the timescale implementation of the TA proc
task but it won't be updating the upload state or deleting/rewriting
the raw upload
new: it will only run the new timescale implementation and it will
update the upload state and rewrite/delete the raw upload