Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow/e2e: only run experimental daemon #5863

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

Benehiko
Copy link
Member

@Benehiko Benehiko commented Feb 24, 2025

- What I did

Only run the daemon in experimental mode for E2E tests.

Closes #5140

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.26%. Comparing base (656523e) to head (c26090b).
Report is 82 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5863      +/-   ##
==========================================
- Coverage   59.27%   59.26%   -0.01%     
==========================================
  Files         353      357       +4     
  Lines       29694    29771      +77     
==========================================
+ Hits        17601    17645      +44     
- Misses      11113    11153      +40     
+ Partials      980      973       -7     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Benehiko Benehiko force-pushed the only-experimental-workflow branch from 4887768 to bed1202 Compare February 24, 2025 13:40
@Benehiko Benehiko force-pushed the only-experimental-workflow branch from bed1202 to 9655637 Compare February 24, 2025 14:43
@Benehiko
Copy link
Member Author

I could cleanup the scripts to always run with an experimental flag or we could keep them there in case we want to have a split between experimental and normal runs? Instead of removing the non-experimental target from the GitHub workflow, I kept it instead but commented out.

@Benehiko Benehiko self-assigned this Feb 24, 2025
@thaJeztah
Copy link
Member

For the daemon, I think we won't be adding new features gated behind experimental - we largely came to the conclusion that a single "experimental" flags was too much of a big-hammer, and instead we now started to put individual options behind options in features (in daemon.json) where we don't want them to be enabled by default. In all cases (including existing ones), experimental options were adding to existing options, so they would always be a superset of what's tested without experimental. From that perspective, I think it's fine if we just have a single option, enable experimental by default in our tests, and remove distinction between "experimental" and "non-experimental".

For tests that test specific experimental features, we should keep the t.Skip though, but those skips should be based on what the daemon returns (i.e., if the daemon indicates it has experimental disabled, then skip the test).

@Benehiko Benehiko force-pushed the only-experimental-workflow branch 2 times, most recently from 53c9739 to ab15fa5 Compare March 10, 2025 10:03
@Benehiko Benehiko marked this pull request as ready for review March 10, 2025 10:33
@Benehiko Benehiko requested a review from a team March 10, 2025 10:33
@Benehiko
Copy link
Member Author

I think I got all the occurrences of experimental-e2e. Please let me know if you know of more places that I might have missed 🙏

@Benehiko Benehiko force-pushed the only-experimental-workflow branch from ab15fa5 to de3a1c6 Compare March 10, 2025 10:36
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
@Benehiko Benehiko force-pushed the only-experimental-workflow branch from de3a1c6 to c26090b Compare March 10, 2025 11:26
@Benehiko Benehiko requested a review from thaJeztah March 10, 2025 11:40
@thaJeztah thaJeztah added status/2-code-review area/testing kind/refactor PR's that refactor, or clean-up code labels Mar 10, 2025
@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 10, 2025
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 70bf6cb into docker:master Mar 10, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: remove "experimental" checks, as they may be redundant
3 participants