-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow/e2e: only run experimental daemon #5863
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5863 +/- ##
==========================================
- Coverage 59.27% 59.26% -0.01%
==========================================
Files 353 357 +4
Lines 29694 29771 +77
==========================================
+ Hits 17601 17645 +44
- Misses 11113 11153 +40
+ Partials 980 973 -7 🚀 New features to boost your workflow:
|
4887768
to
bed1202
Compare
bed1202
to
9655637
Compare
I could cleanup the scripts to always run with an experimental flag or we could keep them there in case we want to have a split between experimental and normal runs? Instead of removing the non-experimental target from the GitHub workflow, I kept it instead but commented out. |
For the daemon, I think we won't be adding new features gated behind For tests that test specific experimental features, we should keep the |
53c9739
to
ab15fa5
Compare
I think I got all the occurrences of |
ab15fa5
to
de3a1c6
Compare
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
de3a1c6
to
c26090b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
- What I did
Only run the daemon in experimental mode for E2E tests.
Closes #5140
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)