-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update minimum go version to go1.23 #5868
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5868 +/- ##
=======================================
Coverage 59.32% 59.32%
=======================================
Files 358 358
Lines 29783 29783
=======================================
Hits 17669 17669
Misses 11145 11145
Partials 969 969 🚀 New features to boost your workflow:
|
Let's discuss if we want to include this in 28.0.1, or keep this for a 28.1 release; this bump was needed if we needed #5869, but the CVE in that bump is really a false positive, so we don't need it for the CLI (other than for silencing scanners). Let me put this in draft, but we can decide what we want to do (mostly trying to keep the diff for the |
c915382
to
4f6cb3a
Compare
Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies; > all: upgrade go directive to at least 1.23.0 [generated] > > By now Go 1.24.0 has been released, and Go 1.22 is no longer supported > per the Go Release Policy (https://go.dev/doc/devel/release#policy). > > For golang/go#69095. This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies; > all: upgrade go directive to at least 1.23.0 [generated] > > By now Go 1.24.0 has been released, and Go 1.22 is no longer supported > per the Go Release Policy (https://go.dev/doc/devel/release#policy). > > For golang/go#69095. This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
4f6cb3a
to
5337b0f
Compare
relates to:
Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies;
This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)