Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check doesn't start for certain changes #763

Open
ldunkum opened this issue Feb 25, 2025 · 0 comments
Open

Check doesn't start for certain changes #763

ldunkum opened this issue Feb 25, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@ldunkum
Copy link

ldunkum commented Feb 25, 2025

Problem Description

What is actually happening

The check for a PR is not starting, it's stuck at:

Starting NOP

initiating...

The PR only adds the following snippet for a repository:

security:
  enableVulnerabilityAlerts: false
  enableAutomatedSecurityFixes: false

I've checked the permissions of the GitHub app and can't find any missing permissions.

What is the expected behavior

That the check starts and shows changes from the PR.

Error output, if available

We can see this in the container logs and in the GitHub app event log, the event type is check_run.created.

  "stack": "TypeError: Cannot read properties of undefined (reading 'additions')\n    at /opt/safe-settings/lib/settings.js:245:29\n    at Array.reduce (<anonymous>)\n    at Settings.handleResults (/opt/safe-settings/lib/settings.js:237:16)\n    at async Settings.sync (/opt/safe-settings/lib/settings.js:52:7)\n    at async Promise.all (index 0)\n    at async Promise.all (index 0)\n    at async middleware (/opt/safe-settings/node_modules/probot/node_modules/@octokit/webhooks/dist-node/index.js:355:5)",
  "type": "Error",
  "msg": "Cannot read properties of undefined (reading 'additions')"

Context

Are you using the hosted instance of probot/settings or running your own?

Selfhosted

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

2.1.16

Version of GitHub Enterprise

@ldunkum ldunkum added the bug Something isn't working label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant