[node-labeler] Refactor node labeling to use taints instead of labels #20652
Conversation
| mgr.GetClient(), | ||
| } | ||
|
|
||
| err = ctrl.NewControllerManagedBy(mgr). |
There was a problem hiding this comment.
The ideal should be achieved under ASG, so that when a node is newly created, it will have the corresponding taint.
However, this may require upgrading infra CF. Therefore, the approach here is a supplement; we will perform a check as soon as the workspace node is created and add the corresponding label and taint.
…t running in Full installation
Co-authored-by: Kyle Brennan <kyle@gitpod.io>
Co-authored-by: Kyle Brennan <kyle@gitpod.io>
What does not support the NoSchedule taint? |
|
for daemon set it will keep waiting until taint remove |
There was a problem hiding this comment.
Adding ✔️ to unblock.
Please see this question: #20652 (comment)
Depending on which workloads are impacted (metrics, logs), we should consider a follow-on PR for prereqs.
All of the things you mentioned are tolerated, only some of the customized optional addons are not. |
|
/unhold |
Description
[node-labeler] Refactor node labeling to use taints instead of labels
Note: It's not a long-term taint, so we don't need to worry too much about interfering with the scheduling of other daemonsets, and I've checked our daemonsets at GCP and AWS, and the vast majority of them tolerate the NoSchedule taint
Related Issue(s)
Fixes CLC-1032
How to test
The best testing method is to use a cell or a ephemeral workspace cluster.
I ran loadgen in my testing cell, it works without problem.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold