Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-labeler] Refactor node labeling to use taints instead of labels #20652

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Mar 5, 2025

Description

[node-labeler] Refactor node labeling to use taints instead of labels

Note: It's not a long-term taint, so we don't need to worry too much about interfering with the scheduling of other daemonsets, and I've checked our daemonsets at GCP and AWS, and the vast majority of them tolerate the NoSchedule taint

Related Issue(s)

Fixes CLC-1032

How to test

The best testing method is to use a cell or a ephemeral workspace cluster.

  1. deploy this node-labeler image to cell or ephemeral workspace cluster
  2. try deleting the ws-daemonset / registry-facade pod to see how it affects the corresponding node's taint
  3. observe how the newly added workspace node handles these taint (We also need other PRs to make ASG create the node with this taint)

I ran loadgen in my testing cell, it works without problem.

image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

mgr.GetClient(),
}

err = ctrl.NewControllerManagedBy(mgr).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ideal should be achieved under ASG, so that when a node is newly created, it will have the corresponding taint.
However, this may require upgrading infra CF. Therefore, the approach here is a supplement; we will perform a check as soon as the workspace node is created and add the corresponding label and taint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants