Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the List component to the sistent components page and updated the content.js file. #6219

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

csengineer1990
Copy link
Contributor

Description

This PR addresses issue #5951 by adding the List component to the Sistent Components page. The necessary content and documentation for the List component have been included, along with updates to the relevant files to ensure consistency.

This PR fixes #5951

Notes for Reviewers
I have made the following changes:

  1. Implemented and documented the List component.
  2. Updated the content.js file to reflect these additions.

I have made the required changes as requested in the previous reviews and aligned them with the issue to ensure a proper resolution.
I would appreciate your review of these updates. Please let me know if any further refinements or additional changes are needed. Thank you!

Signed commits

  • Yes, I signed my commits.

…he content.js

Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 2, 2025

🚀 Preview for commit 5c557f3 at: https://679f638e6e5e0b86aee4c955--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@csengineer1990
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not require to create a separate file for code-block.js you can directly import, so delete this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include example for the List controls like checkbox?

Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have provided few feedback can you look @csengineer1990

import React, { useState } from "react";
import Code from "../../../../../components/CodeBlock";

export const CodeBlock = ({ name, code }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use existing codeblock and don't create a new one please

Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
…oned in the previous request.

Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
@csengineer1990
Copy link
Contributor Author

Made the requested changes by adding examples of List control with checkboxes and removing code-block.js. Apologies for the delayed update. If any further changes are needed, please let me know.

@l5io
Copy link
Contributor

l5io commented Feb 15, 2025

🚀 Preview for commit 2a9bd74 at: https://67b08c32b7f3d319c41cfb1e--layer5.netlify.app

Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

@leecalcote
Copy link
Member

@csengineer1990 please have a look at the merge conflicts here.

@csengineer1990
Copy link
Contributor Author

@csengineer1990 please have a look at the merge conflicts here.

Yes, I will surely resolve the merge conflicts as soon as possible. Thanks for bringing it to my attention!

csengineer1990 and others added 2 commits February 22, 2025 09:52
Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
Signed-off-by: Roshan <68468678+csengineer1990@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Feb 22, 2025

🚀 Preview for commit fefa978 at: https://67b954e04b59d7b097203a3b--layer5.netlify.app

@csengineer1990
Copy link
Contributor Author

I have resolved the merge conflict. Please review the commit and let me know if there are any issues so that I can address them as soon as possible.

Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍
Add this as an agenda item to the meeting minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Sistent] Add List component to the sistent components page
6 participants