Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --output-split-partitions-format API #111

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

romoh
Copy link
Contributor

@romoh romoh commented Feb 10, 2025

Deprecate in favor of COSI.


Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • Code conforms to style guidelines

@romoh romoh force-pushed the user/romoh/deprecate branch 2 times, most recently from b53208e to 25a315e Compare February 12, 2025 00:32
@romoh romoh marked this pull request as ready for review February 12, 2025 00:47
@romoh romoh requested a review from a team as a code owner February 12, 2025 00:47
@romoh romoh changed the title deprecate --output-split-partitions-format API Remove --output-split-partitions-format API Feb 12, 2025
@romoh romoh force-pushed the user/romoh/deprecate branch from 2d83edc to 3408750 Compare February 13, 2025 17:35
@romoh romoh marked this pull request as draft February 20, 2025 22:58
@romoh romoh marked this pull request as ready for review March 5, 2025 20:58
@cwize1
Copy link
Contributor

cwize1 commented Mar 5, 2025

This change is sitting on top of a commit that is a few weeks old and there are merge conflicts. It would be good to rebase.

@himaja-kesari himaja-kesari force-pushed the user/romoh/deprecate branch 4 times, most recently from 8d8ad18 to eccbee3 Compare March 6, 2025 17:52
@himaja-kesari himaja-kesari force-pushed the user/romoh/deprecate branch from eccbee3 to 22dd723 Compare March 6, 2025 19:51
Signed-off-by: Roaa Sakr <romoh@microsoft.com>

docs update

Signed-off-by: Roaa Sakr <romoh@microsoft.com>

add support for shrinking cosi paritions

Signed-off-by: Roaa Sakr <romoh@microsoft.com>

update docs

Signed-off-by: Roaa Sakr <romoh@microsoft.com>

update

Signed-off-by: Roaa Sakr <romoh@microsoft.com>

fix docs

Signed-off-by: Roaa Sakr <romoh@microsoft.com>

fix

Signed-off-by: Roaa Sakr <romoh@microsoft.com>

tests

Signed-off-by: Roaa Sakr <romoh@microsoft.com>

wip

Signed-off-by: Roaa Sakr <romoh@microsoft.com>
@himaja-kesari himaja-kesari force-pushed the user/romoh/deprecate branch from 22dd723 to e833ae1 Compare March 6, 2025 19:57
@himaja-kesari himaja-kesari force-pushed the user/romoh/deprecate branch 3 times, most recently from 8a96e22 to bf297d3 Compare March 6, 2025 20:21
cwize1
cwize1 previously approved these changes Mar 6, 2025
@himaja-kesari himaja-kesari merged commit 40fe6c0 into main Mar 6, 2025
7 checks passed
@himaja-kesari himaja-kesari deleted the user/romoh/deprecate branch March 6, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants