Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable perf tui #12809

Closed
wants to merge 4 commits into from
Closed

Enable perf tui #12809

wants to merge 4 commits into from

Conversation

AZaugg
Copy link
Contributor

@AZaugg AZaugg commented Mar 4, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Enables perf tui

https://github.com/torvalds/linux/blob/99fa936e8e4f117d62f229003c9799686f74cebc/tools/perf/Makefile.config#L781

Change Log
  • Add slang-devl package to BuildRequires on kernel spec file
Does this affect the toolchain?

YES

Test Methodology
  • Pipeline build id: 753376

@AZaugg
Adding sland-devel to kernel spec, enabling perf tui
5288faf 
Perf's Makefile has a slang-devel check, which enables tui when
slang is detected. Adding this package at built time will allow
perf --tui support
@AZaugg AZaugg requested a review from a team as a code owner March 4, 2025 20:10
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Mar 4, 2025
@christopherco
Copy link
Contributor

Superseded by #12820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AZaugg @christopherco