Android Builds Failing in Latest GH Actions

[nibanks]

Describe the bug

https://github.com/microsoft/msquic/actions/runs/13514388510/job/37760398206?pr=4853

In file included from <built-in>:398:
<command line>:23:9: warning: '__ANDROID_API__' macro redefined [-Wmacro-redefined]
   23 | #define __ANDROID_API__ 29
      |         ^
<built-in>:390:9: note: previous definition is here
  390 | #define __ANDROID_API__ __ANDROID_MIN_SDK_VERSION__
      |         ^
In file included from <built-in>:398:
<command line>:23:9: warning: '__ANDROID_API__' macro redefined [-Wmacro-redefined]
   23 | #define __ANDROID_API__ 29
      |         ^
...

From past experience, this is caused by GitHub build machines changing Android versions, but it may be a different issue this time.

Affected OS

• Windows
• Linux
• macOS
• Other (specify below)

Additional OS information

No response

MsQuic version

main

Steps taken to reproduce bug

Create a PR

Expected behavior

All CI builds pass

Actual outcome

Android is failing.

Additional details

No response

[vgmahajanshetty]

There were few errors related to unused-result:

/home/runner/work/msquic/msquic/src/tools/sample/sample.c:667:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
667 | getchar();
| ^~~~~~~
1 error generated.
gmake[2]: *** [src/tools/sample/CMakeFiles/quicsample.dir/build.make:79: src/tools/sample/CMakeFiles/quicsample.dir/sample.c.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1171: src/tools/sample/CMakeFiles/quicsample.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake[2]: Leaving directory '/home/runner/work/msquic/msquic/build/android/x64_openssl'
/home/runner/work/msquic/msquic/src/tools/interopserver/InteropServer.cpp:137:13: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
137 | getchar();
| ^~~~~~~
1 error generated.

These are fixed in draft PR, but unable to proceed to build due to tool chain issue with OpenSSL3 on Android (NDK) as below:

Configuring OpenSSL version 3.1.4+quic for target android-x86_64
Using os-specific seed configuration
Failure! build file wasn't produced.
gmake[2]: Leaving directory '/home/runner/work/msquic/msquic/build/android/x64_openssl3'
Please read INSTALL.md and associated NOTES-* files. You may also have to
look over your available compiler tool chain or change your configuration.

no NDK x86_64-linux-android-gcc on $PATH at (eval 10) line 142.
gmake[2]: *** [_deps/opensslquic-build/CMakeFiles/OpenSSL_Target.dir/build.make:81: _deps/opensslquic-build/submodules/openssl3/Makefile] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:700: _deps/opensslquic-build/CMakeFiles/OpenSSL_Target.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

When OpenSSL 3.1 was being configured, it started looking for x86_64-linux-android-gcc, I think it should start using Clang instead of gcc; probably this is some configuration issue on OpenSSL3.1 on Android.